This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix unit test failure from pull request #4878. Added unit test for hiding Active Line highlight when editor has selection. #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RaymondLim and @jasonsanjose, here's the new unit test and the fix for the old unit test failure. |
ghost
assigned 
| @@ -1478,6 +1478,14 @@ define(function (require, exports, module) { | |||
| function _setEditorOption(value, cmOption) { | |||
| _instances.forEach(function (editor) { | |||
| editor._codeMirror.setOption(cmOption, value); | |||
|
|
|||
| // If there is a selection in the editor, temporarily hide Active Line Highlight | |||
| if ((cmOption === "styleActiveLine") && (value === true)) { | |||
There was a problem hiding this comment.
Nice to have this here since it takes care of all editors, not just the main editor that you took care of in your previous implementation.
|
Travis build passed after I restarted. Merging now. |
RaymondLim
added a commit
that referenced
this pull request
Aug 26, 2013
Fix unit test failure from pull request #4878. Added unit test for hiding Active Line highlight when editor has selection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the fix for the unit test errors caused by pull request #4878. I moved the check out of the toggle command code and into the _setEditorOption() code per the suggestion of @jasonsanjose.
I also added a new unit test to check for the temporary hiding of the Active Line Highlight when there is an editor selection. Tested the positive and negative scenarios. Ran the entire test suite. Everything looks good. There are still quite a few errors in the unit test suite right now, but none appear to be related to my changes.