Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Insert space after colon for CSS code hints #6317

Merged
merged 1 commit into from
Jan 8, 2014

Conversation

stowball
Copy link
Contributor

Everybody writes a space after the colon in CSS properties, but Brackets doesn't insert them by default. This fixes that.

@ghost ghost assigned couzteau Jan 2, 2014
@couzteau
Copy link
Member

couzteau commented Jan 3, 2014

Hi @stowball, we are holding back because we think wether to add the whitespace after the colon may be a project or user specific preference. The preferences story is currently being worked on: https://trello.com/c/kqFFDqhR/523-3-infrastructure-for-project-file-scoped-preferences

@stowball
Copy link
Contributor Author

stowball commented Jan 3, 2014

I’m all for adding preferences to let the user control as much as they want in the app (in fact I’d love it), but with all the developers I’ve worked with, and all the third party code I’ve used (plugins etc), I have never seen anyone who doesn’t use a space after the colon. It seems to be the default in every editor I’ve used also.

Brackets source LESS files even have the space after the colon. So, if Brackets really is built with Brackets, this will save the developers thousands of keystrokes every year :)

My 2 cents

@marcelgerber
Copy link
Contributor

Maybe we could set it to add a space after the colon by default, but this could be changed to "no space after colon" in the preferences ;)

@couzteau
Copy link
Member

couzteau commented Jan 3, 2014

I agree that this is a useful improvement. Trying to get approval from the team.

@sbruchmann
Copy link

+1 for what @SAplayer said. I never saw anyone omitting the space after the colon.

@couzteau
Copy link
Member

couzteau commented Jan 6, 2014

There is a thread on brackets-dev on this: https://groups.google.com/forum/?fromgroups#!topic/brackets-dev/oSft7wZGgb0 Planning to go ahead and merge the pull request by end of day today if I don't hear any objections.

@couzteau
Copy link
Member

couzteau commented Jan 7, 2014

Holding back the merge until #6392 is resolved

@couzteau
Copy link
Member

couzteau commented Jan 8, 2014

Tested again, in particular made sure #6392 does not come back. Looking good, merging now.

couzteau added a commit that referenced this pull request Jan 8, 2014
Insert space after colon for CSS code hints
@couzteau couzteau merged commit 7544253 into adobe:master Jan 8, 2014
@pi7dets
Copy link

pi7dets commented Feb 17, 2020

Here, I found the guilty ones. Just because Dreamweaver uses Brackets I can't upgrade to the new version for about 6 years because now there is always a space after a colon in CSS.
To put a space or not, this should be in the settings.
After all, maybe those who have been writing code for 2-3 years haven't noticed it, but I've been doing it since the first version of DW and all these new things with spaces are very annoying.
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants