Update Less to 1.7.0 #6730

WebsiteDeveloper · 2014-02-01T09:22:33Z

Updating less for improvements made since 1.4.2
See https://github.com/less/less.js/blob/master/CHANGELOG.md for more detailed information.

njx · 2014-02-10T19:01:50Z

To @redmunds. Seems like there's some potential testing risk - please assess. Also note that there's a spurious CM SHA commit in here.

njx · 2014-02-10T19:06:17Z

Also, as a general rule, we only really want to update stuff like this if there's a major win to be had from upgrading (i.e., it fixes a major bug that affects us, has major performance gains, etc.) If none of those apply, we shouldn't upgrade now, because there's a cost in testing and potential destabilization.

WebsiteDeveloper · 2014-02-10T19:09:22Z

I will remove the CM commit.
There is a performance improvement of about 30-40% as stated in the Changelog, this is the most notable improvement, for which i did this pull.

redmunds · 2014-02-10T22:48:51Z

src/thirdparty/CodeMirror2

@@ -1 +1 @@
-Subproject commit 5ccfedfb0a22a95ec6e28f7475d1bac9c349ce82
+Subproject commit 5581979d2c624d6c32342e50bb417749ad799ee7


I don't think you intended to change the CodeMirror SHA, right?

WebsiteDeveloper · 2014-02-11T10:33:31Z

@redmunds all fixed.

redmunds · 2014-02-12T00:05:44Z

@WebsiteDeveloper On Mac, the time spent processing brackets.less dropped from 600ms to 535ms, which is >10% improvement. Nice.

But, many unnecessary messages are written to the console. Can you get rid of these?

less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_shared.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/bootstrap.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/variables.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/mixins.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/reset.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/scaffolding.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/grid.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/layouts.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/type.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/code.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/forms.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/tables.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/sprites.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/dropdowns.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/wells.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/component-animations.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/close.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/buttons.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/button-groups.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/alerts.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/navs.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/navbar.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/breadcrumbs.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/pagination.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/pager.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/modals.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/tooltip.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/popovers.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/thumbnails.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/media.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/labels-badges.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/progress-bars.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/accordion.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/carousel.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/hero-unit.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/bootstrap/utilities.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_variables.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_mixins.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_patterns_override.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_fonts.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_colors.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_theme_default.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_codemirror_override.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/jsTreeTheme.less' less-1.6.2.min.js:13
less: XHR: Getting 'file://localhost/Users/randyedmunds/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/src/styles/brackets_scrollbars.less' less-1.6.2.min.js:13

WebsiteDeveloper · 2014-02-12T09:36:26Z

We could set the logLevel of less to errors. But that would also stop showing the performance data.
I already opened a bug against the less repo to only log the preformance values less/less.js#1856

peterflynn · 2014-02-12T09:47:39Z

@redmunds @WebsiteDeveloper Note that the speed improvement will not benefit most Brackets users -- only Brackets developers -- since the LESS is pre-compiled in release builds these days.

WebsiteDeveloper · 2014-03-10T16:08:29Z

@redmunds changes pushed

redmunds · 2014-03-16T02:11:12Z

src/index.html

@@ -46,7 +46,8 @@

    <!-- Pre-load third party scripts that cannot be async loaded. -->
    <!-- build:js thirdparty/thirdparty.min.js -->
-    <script src="thirdparty/less-1.4.2.min.js"></script>
+    <script src="config.js"></script>


I'm not crazy about the idea of introducing a new top-level script include file just to set the logging level, and it creates an object in the global namespace. I'll have to see what the rest of the team thinks about that.

At the very least this file needs to be renamed to something more descriptive such as less-config.js and moved to the thirdparty/ folder.

I didn't like the idea either but as to the object in global namespace, less does that anyway.
I also thought of changing the default value in less itself.
The reason i put this into a file is that we can't include inline scripts for chromebook deployment.

This will be ok. Please move and rename the new file to thirdparty/less-config.js.

@WebsiteDeveloper I forgot to add your id, so maybe you missed my previous comment?

WebsiteDeveloper · 2014-05-09T20:27:32Z

@redmunds sorry for my long response time, i have not had the time to work on this in the last few months.
I finally found the time to make this small change. So ready for another review.

redmunds · 2014-05-13T15:57:55Z

Looks good. Merging.

Update Less to 1.7.0

WebsiteDeveloper · 2014-05-13T16:32:09Z

Finally

WebsiteDeveloper added 2 commits February 7, 2014 19:09

Update Less to 1.6.2

c172614

Fix parsing error

b3a77f8

njx assigned redmunds Feb 10, 2014

redmunds reviewed Feb 10, 2014
View reviewed changes

Merge branch 'master' into lessUpdate

60fa486

WebsiteDeveloper added 2 commits March 10, 2014 17:04

Update less to 1.7.0 to remove unnessecarry log messages

842a03c

Add newline at end of file

fb46548

redmunds reviewed Mar 16, 2014
View reviewed changes

le717 mentioned this pull request Mar 18, 2014

Fix a case when extension less file is importing other less files #7230

Merged

redmunds mentioned this pull request May 2, 2014

Make html menus scroll to avoid truncation #7731

Merged

WebsiteDeveloper added 2 commits May 9, 2014 22:20

Merge remote-tracking branch 'upstream/master' into lessUpdate

6bc8002

Change filename of less config file

6b91317

redmunds added a commit that referenced this pull request May 13, 2014

Merge pull request #6730 from WebsiteDeveloper/lessUpdate

0e5d4ce

Update Less to 1.7.0

redmunds merged commit 0e5d4ce into adobe:master May 13, 2014

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] Update Less to 1.7.0 brackets-archive/bracketsIssues#6107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Less to 1.7.0 #6730

Update Less to 1.7.0 #6730

WebsiteDeveloper commented Feb 1, 2014

njx commented Feb 10, 2014

njx commented Feb 10, 2014

WebsiteDeveloper commented Feb 10, 2014

redmunds Feb 10, 2014

WebsiteDeveloper Feb 11, 2014

WebsiteDeveloper commented Feb 11, 2014

redmunds commented Feb 12, 2014

WebsiteDeveloper commented Feb 12, 2014

peterflynn commented Feb 12, 2014

WebsiteDeveloper commented Mar 10, 2014

redmunds Mar 16, 2014

WebsiteDeveloper Mar 16, 2014

redmunds Mar 20, 2014

redmunds Apr 28, 2014

WebsiteDeveloper commented May 9, 2014

redmunds commented May 13, 2014

WebsiteDeveloper commented May 13, 2014

		@@ -1 +1 @@
		Subproject commit 5ccfedfb0a22a95ec6e28f7475d1bac9c349ce82
		Subproject commit 5581979d2c624d6c32342e50bb417749ad799ee7

Update Less to 1.7.0 #6730

Update Less to 1.7.0 #6730

Conversation

WebsiteDeveloper commented Feb 1, 2014

njx commented Feb 10, 2014

njx commented Feb 10, 2014

WebsiteDeveloper commented Feb 10, 2014

redmunds Feb 10, 2014

Choose a reason for hiding this comment

WebsiteDeveloper Feb 11, 2014

Choose a reason for hiding this comment

WebsiteDeveloper commented Feb 11, 2014

redmunds commented Feb 12, 2014

WebsiteDeveloper commented Feb 12, 2014

peterflynn commented Feb 12, 2014

WebsiteDeveloper commented Mar 10, 2014

redmunds Mar 16, 2014

Choose a reason for hiding this comment

WebsiteDeveloper Mar 16, 2014

Choose a reason for hiding this comment

redmunds Mar 20, 2014

Choose a reason for hiding this comment

redmunds Apr 28, 2014

Choose a reason for hiding this comment

WebsiteDeveloper commented May 9, 2014

redmunds commented May 13, 2014

WebsiteDeveloper commented May 13, 2014