Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Enable image viewer for .ico files #7201

Merged
merged 1 commit into from
Mar 19, 2014

Conversation

marcelgerber
Copy link
Contributor

For #7017 @peterflynn @larz0
This adds .ico files to the image language and attaches a largest label to a shown ico file (as discussed in the issue).

@@ -312,7 +313,11 @@ define(function (require, exports, module) {
$("#img-preview").on("load", function () {
// add dimensions and size
_naturalWidth = this.naturalWidth;
var ext = FileUtils.getFileExtension(fullPath);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better approach to get the file extension (maybe passed through)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems reasonable to me. It's not going to be a performance bottleneck, if that's the concern...

@RaymondLim
Copy link
Contributor

Looks good. Merging.

RaymondLim added a commit that referenced this pull request Mar 19, 2014
Enable image viewer for .ico files
@RaymondLim RaymondLim merged commit cd86e0f into adobe:master Mar 19, 2014
@marcelgerber marcelgerber deleted the image-viewer-ico branch March 19, 2014 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants