This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix convertPreferences to accept non-module clientIDs #7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be cool if this gets into Sprint 38. |
|
Thanks for fixing this, @SAplayer ! I was just about to investigate doing the same thing for a different extension that was using a different client ID as well. Finished code review. Merging... |
bchintx
added a commit
that referenced
this pull request
Apr 7, 2014
Fix convertPreferences to accept non-module clientIDs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick story:
I wanted to update the Theseus preferences system (adobe-research/theseus#55), but after a while I saw that convertPreferences will only work if the passed
clientIDismodule. But in the case of Theseus, strings are used as clientID (likecom.adobe.theseus).This fixes this issue.