New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency to winston #466

Closed

tripodsan opened this issue Jan 17, 2019 · 0 comments · Fixed by #469

Labels

Contributor

tripodsan commented Jan 17, 2019 •

edited

Loading

as explained in #433, we should hide winston as implementation detail inside helix-shared and add the missing features to helix-shared/Logger.

after that, we can drop the dependency to winston in helix-cli.

also see adobe/helix-shared#33

tripodsan added the enhancement label

tripodsan added a commit that referenced this issue


          remove dependency to winston #466

84268c2

tripodsan mentioned this issue

remove dependency to winston #466 #469

Merged

tripodsan closed this as completed in #469

tripodsan added a commit that referenced this issue


          remove dependency to winston #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment