fix: sitemap language should not allow lastmod (#1020)

adobe · Oct 29, 2024 · e3d5dd0 · e3d5dd0
1 parent 311ef42
commit e3d5dd0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/packages/helix-shared-config/src/schemas/sitemap-language.schema.json b/packages/helix-shared-config/src/schemas/sitemap-language.schema.json
@@ -65,6 +65,7 @@
       ]
     }
   },
+  "additionalProperties": false,
   "required": [
     "destination",
     "hreflang"

diff --git a/packages/helix-shared-config/test/sitemapconfigs.test.js b/packages/helix-shared-config/test/sitemapconfigs.test.js
@@ -66,6 +66,12 @@ HREF Language must match pattern`,
     error: `Error: Invalid configuration:
 HREF Language must match pattern`,
   },
+  {
+    title: 'loads an example with a language defining lastmod',
+    config: 'broken5.yaml',
+    error: `Error: Invalid configuration:
+Sitemap Language has unknown property 'lastmod'`,
+  },
 ];
 
 describe('Sitemap Config Loading', () => {

diff --git a/packages/helix-shared-config/test/specs/sitemapconfigs/broken5.yaml b/packages/helix-shared-config/test/specs/sitemapconfigs/broken5.yaml
@@ -0,0 +1,11 @@
+version: 1
+
+sitemaps:
+  broken:
+    origin: https://www.example.com
+    languages:
+      en:
+        source: /query-index.json
+        destination: /sitemap-en.xml
+        hreflang: en
+        lastmod: YYYY-MM-DD