From dacddc45cbaafeaa030c93398ddf6676117b38bf Mon Sep 17 00:00:00 2001 From: Reid Barber Date: Thu, 9 Oct 2025 17:33:07 -0500 Subject: [PATCH 1/3] revert S2 modal position change --- packages/@react-spectrum/s2/src/Modal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@react-spectrum/s2/src/Modal.tsx b/packages/@react-spectrum/s2/src/Modal.tsx index fdf5bcb831f..018f16789de 100644 --- a/packages/@react-spectrum/s2/src/Modal.tsx +++ b/packages/@react-spectrum/s2/src/Modal.tsx @@ -29,7 +29,7 @@ interface ModalProps extends ModalOverlayProps { const modalOverlayStyles = style({ ...colorScheme(), - position: 'fixed', + position: 'absolute', top: 0, left: 0, width: 'full', From 9d195d84b0f34714682c7818824c61497560df44 Mon Sep 17 00:00:00 2001 From: Reid Barber Date: Thu, 9 Oct 2025 17:35:28 -0500 Subject: [PATCH 2/3] fix S2 docs menu modal position --- packages/dev/s2-docs/src/MobileHeader.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev/s2-docs/src/MobileHeader.tsx b/packages/dev/s2-docs/src/MobileHeader.tsx index dc8e34a8c6f..b282ea81512 100644 --- a/packages/dev/s2-docs/src/MobileHeader.tsx +++ b/packages/dev/s2-docs/src/MobileHeader.tsx @@ -162,7 +162,7 @@ export function MobileHeader({toc, pages, currentPage}) { - + From 9cb26189240f372c1307a184f8e8ad400b7c9fa0 Mon Sep 17 00:00:00 2001 From: Reid Barber Date: Thu, 9 Oct 2025 17:36:24 -0500 Subject: [PATCH 3/3] s2: fix ModalProps types --- packages/@react-spectrum/s2/src/Modal.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/@react-spectrum/s2/src/Modal.tsx b/packages/@react-spectrum/s2/src/Modal.tsx index 018f16789de..ad55a2b3b24 100644 --- a/packages/@react-spectrum/s2/src/Modal.tsx +++ b/packages/@react-spectrum/s2/src/Modal.tsx @@ -12,13 +12,13 @@ import {colorScheme} from './style-utils' with {type: 'macro'}; import {ColorSchemeContext} from './Provider'; -import {DOMRef} from '@react-types/shared'; +import {DOMRef, GlobalDOMAttributes} from '@react-types/shared'; import {forwardRef, MutableRefObject, useCallback, useContext} from 'react'; import {ModalOverlay, ModalOverlayProps, Modal as RACModal, useLocale} from 'react-aria-components'; import {style} from '../style' with {type: 'macro'}; import {useDOMRef} from '@react-spectrum/utils'; -interface ModalProps extends ModalOverlayProps { +interface ModalProps extends Omit { /** * The size of the Modal. *