Skip to content

Commit 7ab0fc6

Browse files
revert: feat(dialog-base): add dismissHelper for visually-hidden buttons
we do not need to provide a close/visually hidden button for non-dismissible dialogs
1 parent 3444d05 commit 7ab0fc6

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

packages/dialog/src/DialogBase.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -194,23 +194,6 @@ export class DialogBase extends FocusVisiblePolyfillMixin(SpectrumElement) {
194194
super.update(changes);
195195
}
196196

197-
/**
198-
* Returns a visually hidden dismiss button for mobile screen reader accessibility.
199-
* This button is placed before and after dialog content to allow mobile screen reader
200-
* users (particularly VoiceOver on iOS) to easily dismiss the overlay.
201-
*/
202-
protected get dismissHelper(): TemplateResult {
203-
return html`
204-
<div class="visually-hidden">
205-
<button
206-
tabindex="-1"
207-
aria-label="Dismiss"
208-
@click=${this.close}
209-
></button>
210-
</div>
211-
`;
212-
}
213-
214197
protected renderDialog(): TemplateResult {
215198
return html`
216199
<slot></slot>

0 commit comments

Comments
 (0)