-
Notifications
You must be signed in to change notification settings - Fork 236
docs(help-text,combobox,radio-group): updates documentation to properly use negative-help-text #5828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ly use negative-help-text
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 18841796323Details
💛 - Coveralls |
caseyisonit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG ITS GLORIOUS
| - An overall description of an input field or controls | ||
| - Hints for what kind of information needs to be inputted or selected | ||
| - Specific formatting examples or requirements | ||
| - An overall description of an input field or controls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have been a lint change, but I think it's right, so I left it. Happy to revert if folks think this is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have linting issues between different users i think, its something we've always accepted but should be more perscriptive in second-gen
Description
Updates doc files for
help-text,combobox, andradio-groupto properly show examples of using negative help text. This also shows the correct behavior in examples (see screenshots below).Related issue(s)
Screenshots (if appropriate)
Before

After

Author's checklist
I have added automated tests to cover my changes.I have included a well-written changeset if my change needs to be published.Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Documentation Quality