From 1da56306636fa26b6d1596f1d96867f3319f8402 Mon Sep 17 00:00:00 2001 From: sukamat Date: Tue, 19 Nov 2024 15:57:58 -0800 Subject: [PATCH] refactor and made function private --- tools/floodbox/graybox/graybox-config.js | 50 +++++++++++++++--------- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/tools/floodbox/graybox/graybox-config.js b/tools/floodbox/graybox/graybox-config.js index ce39f68a54..0f2029989e 100644 --- a/tools/floodbox/graybox/graybox-config.js +++ b/tools/floodbox/graybox/graybox-config.js @@ -32,30 +32,18 @@ class GrayboxConfig { const resp = await this.requestHandler.daFetch(`${DA_ORIGIN}/source/${this.org}/${this.repo}${GRAYBOX_CONFIG_FILE}`); if (resp.ok) { const json = await resp.json(); - const { 'global-config': globalConfig, 'experience-config': experienceConfig, 'global-promote-ignore-paths': globalPromoteIgnorePathsConfig } = json; + const { + 'global-config': globalConfig, + 'experience-config': experienceConfig, + 'global-promote-ignore-paths': globalPromoteIgnorePathsConfig, + } = json; if (globalConfig) { - const enablePromoteConfig = globalConfig.data.find(({ key }) => key === 'enablePromote'); - this.isGlobalPromoteEnabled = !enablePromoteConfig || enablePromoteConfig.value === '' ? null : enablePromoteConfig.value === 'true'; - const enableDeleteConfig = globalConfig.data.find(({ key }) => key === 'enableDelete'); - this.isGlobalDeleteEnabled = !enableDeleteConfig || enableDeleteConfig.value === '' ? null : enableDeleteConfig.value === 'true'; - const promoteDraftsOnlyConfig = globalConfig.data.find(({ key }) => key === 'promoteDraftsOnly'); - this.isGlobalPromoteDraftsOnly = !promoteDraftsOnlyConfig || promoteDraftsOnlyConfig.value === '' ? null : promoteDraftsOnlyConfig.value === 'true'; + this.#setGlobalConfig(globalConfig); } if (experienceConfig) { - const promoteConfig = experienceConfig.data.find(({ key }) => key === 'enablePromote'); - if (promoteConfig) { - this.experiencePromoteConfig = promoteConfig.experienceNames.split(',').map((expName) => expName.trim()); - } - const deleteConfig = experienceConfig.data.find(({ key }) => key === 'enableDelete'); - if (deleteConfig) { - this.experienceDeleteConfig = deleteConfig.experienceNames.split(',').map((expName) => expName.trim()); - } - const draftsOnlyConfig = experienceConfig.data.find(({ key }) => key === 'promoteDraftsOnly'); - if (draftsOnlyConfig) { - this.experienceDraftsOnlyConfig = draftsOnlyConfig.experienceNames.split(',').map((expName) => expName.trim()); - } + this.#setExperienceConfig(experienceConfig); } if (globalPromoteIgnorePathsConfig) { @@ -93,6 +81,30 @@ class GrayboxConfig { getGlobalPromoteIgnorePaths() { return this.globalPromoteIgnorePaths; } + + #setGlobalConfig(globalConfig) { + const enablePromoteConfig = globalConfig.data.find(({ key }) => key === 'enablePromote'); + this.isGlobalPromoteEnabled = !enablePromoteConfig || enablePromoteConfig.value === '' ? null : enablePromoteConfig.value === 'true'; + const enableDeleteConfig = globalConfig.data.find(({ key }) => key === 'enableDelete'); + this.isGlobalDeleteEnabled = !enableDeleteConfig || enableDeleteConfig.value === '' ? null : enableDeleteConfig.value === 'true'; + const promoteDraftsOnlyConfig = globalConfig.data.find(({ key }) => key === 'promoteDraftsOnly'); + this.isGlobalPromoteDraftsOnly = !promoteDraftsOnlyConfig || promoteDraftsOnlyConfig.value === '' ? null : promoteDraftsOnlyConfig.value === 'true'; + } + + #setExperienceConfig(experienceConfig) { + const promoteConfig = experienceConfig.data.find(({ key }) => key === 'enablePromote'); + if (promoteConfig) { + this.experiencePromoteConfig = promoteConfig.experienceNames.split(',').map((expName) => expName.trim()); + } + const deleteConfig = experienceConfig.data.find(({ key }) => key === 'enableDelete'); + if (deleteConfig) { + this.experienceDeleteConfig = deleteConfig.experienceNames.split(',').map((expName) => expName.trim()); + } + const draftsOnlyConfig = experienceConfig.data.find(({ key }) => key === 'promoteDraftsOnly'); + if (draftsOnlyConfig) { + this.experienceDraftsOnlyConfig = draftsOnlyConfig.experienceNames.split(',').map((expName) => expName.trim()); + } + } } export default GrayboxConfig;