Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Delete deprecated first-responder-inputs-initializer #493

Merged
merged 5 commits into from
Nov 19, 2021
Merged

[Breaking] Delete deprecated first-responder-inputs-initializer #493

merged 5 commits into from
Nov 19, 2021

Conversation

SergeAstapov
Copy link
Contributor

Part of #116.

Similar to #461 but focuses on one thing at a time.

@SergeAstapov SergeAstapov marked this pull request as draft November 17, 2021 03:43
@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented Nov 17, 2021 •
edited
Loading

Logic about disableInputsInitializer configuration warning needs to be updated as it does not make effect, need to pull config/environment instead of app.options.
Will update shortly.

@SergeAstapov SergeAstapov marked this pull request as ready for review November 17, 2021 06:00
@SergeAstapov
Copy link
Contributor Author

This is now working as expected and is ready for review.

lukemelia
lukemelia approved these changes Nov 19, 2021
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@lukemelia lukemelia merged commit 1a21943 into adopted-ember-addons:master Nov 19, 2021
@SergeAstapov SergeAstapov deleted the delete-first-responder-inputs-initializer branch November 19, 2021 03:18
leoeuclids pushed a commit to leoeuclids/ember-keyboard that referenced this pull request Dec 11, 2023
@NullVoxPopuli
Merge pull request adopted-ember-addons#493 from nicolechung/handle_e…
f6508a1 
…lement_in_sortable_item_most_recent

fix: Handle element in sortable item should be the most recent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemelia lukemelia Awaiting requested review from lukemelia

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @lukemelia