Delete deprecated mixins #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
force-pushed
the
delete-deprecated-mixins
branch
from
a1892ca to
acbf3dd
Compare
SergeAstapov
commented
Nov 21, 2021
|
|
||
| ```htmlbars | ||
| {{input}} | ||
| <input {{on-key '/' this.onSlash}} /> |
There was a problem hiding this comment.
@lukemelia do you mind to take a look into this example? I'm not 100% sure this is the exactly right way
There was a problem hiding this comment.
This looks as I would expect.
lukemelia
approved these changes
Nov 21, 2021
|
|
||
| ```htmlbars | ||
| {{input}} | ||
| <input {{on-key '/' this.onSlash}} /> |
There was a problem hiding this comment.
This looks as I would expect.
|
@SergeAstapov what do you want to do about the Ember 3.8 failure? |
|
@lukemelia I’m working on the fix. I’ll push an update once I have it |
|
@lukemelia found the solution for 3.8 scenario - in the test component used |
|
Thanks, @SergeAstapov. Seems OK until we drop 3.8 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #116.