Migrate to pnpm #772
Migrate to pnpm #772
Conversation
leoeuclids
force-pushed
the
migration/pnpm
branch
3 times, most recently
from
c19530d to
f0578b8
Compare
leoeuclids
force-pushed
the
migration/pnpm
branch
from
f0578b8 to
654e96b
Compare
.github/workflows/ci.yml
Outdated
| @@ -19,25 +19,20 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - name: Install Node | |||
| uses: actions/setup-node@v3 | |||
| - uses: wyvox/action-setup-pnpm@v2 | |||
There was a problem hiding this comment.
minor, this was removed from addon blueprint recently https://github.com/embroider-build/addon-blueprint/blob/main/files/.github/workflows/ci.yml#L22
| @@ -16,17 +16,12 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - name: Install Node | |||
| uses: actions/setup-node@v3 | |||
| - uses: wyvox/action-setup-pnpm@v2 | |||
There was a problem hiding this comment.
note for next step - replace this with put-built-npm-package-contents-on-branch per https://github.com/embroider-build/addon-blueprint/blob/main/files/.github/workflows/push-dist.yml
There was a problem hiding this comment.
I've swapped the wyvox/action-setup-pnpm@v2 for the pnpm/action-setup@v3, as per the blueprint, but I'm not sure how to incorporate the put-built-npm-package-contents-on-branch in it. Should it just be added as the next step after Install dependecies?
There was a problem hiding this comment.
@leoeuclids we basically should update this whole file to match https://github.com/embroider-build/addon-blueprint/blob/main/files/.github/workflows/push-dist.yml (replacing placeholders and if/else branching of course) we can do that in follow up PR
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "release-plan": "^0.8.0" | ||
| }, | ||
| "volta": { | ||
| "node": "16.20.0", | ||
| "yarn": "1.22.18" | ||
| "node": "16.20.0" |
There was a problem hiding this comment.
as we bump for CI, worth to bump for development as well?
|
Thank you @leoeuclids! |
|
Thank you @SergeAstapov! |
Migrates to pnpm
ember-cli-fastboot@4