Fixing virtual scrollbar flip flopping. Closes #552. #665
+138
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmurphey
force-pushed
the
virtual-scrollbar-settling
branch
from
1278b6d
to
4f33a20
Compare
When using a virtual scrollbar, the table body was rerendered as the virtual scrollbar flag was settling.
gmurphey
force-pushed
the
virtual-scrollbar-settling
branch
from
4f33a20
to
706d0ff
Compare
|
Hi @gmurphey I realize this has been open a long time, but could you possibly rebase? |
|
@gmurphey Thanks for the PR! We've recently made a lot of significant changes to ember-light-table. Can you please rebase your PR and make sure everything is still working as intended? If this PR is no longer necessary after the new changes, please close it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a virtual scrollbar, the table body was rerendered as the virtual scrollbar flag was settling.