-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use coma in numbers #25
base: master
Are you sure you want to change the base?
Conversation
@GCorbel I agree with you, this is certainly an issue I havent faced yet. Im not really sure if this is the best approach though or if it will break anything upstream. |
It works for me. We may have an option like |
@offirgolan I need your feedback for one project. Please, let me know if you think my proposition is good or not. |
@GCorbel I'm sorry but I'm on vacation and I dont have time to check this logic out for the next 2 weeks. If you are using this via ember-cp-validations, you have multiple ways of doing this with public API.
Hopefully that will unblock you until I have more time to verify this PR. |
@offirgolan This PR looks relatively straightforward, any chance we can get it merged? |
@GCorbel can we put this behind an |
@offirgolan sorry for late answer. I will check it this weekend I hope. |
In french, and in some other languages, coma are used instead of dos to separate numbers.
Not sure about the implementation but I didn't found an other way.