Skip to content

Commit

Permalink
disable test that do not work with Ratis OM
Browse files Browse the repository at this point in the history
  • Loading branch information
adoroszlai committed Dec 6, 2024
1 parent 379056f commit 34df4ed
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.hadoop.util.Time;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Unhealthy;
import org.apache.ratis.protocol.ClientId;
import org.apache.ratis.protocol.Message;
import org.apache.ratis.protocol.RaftClientReply;
Expand Down Expand Up @@ -1321,6 +1322,7 @@ public void testNormalKeyOverwriteHSyncKey() throws Exception {
}

@Test
@Unhealthy("HDDS-11870")
public void testHSyncKeyOverwriteNormalKey() throws Exception {
// Set the fs.defaultFS
final String rootPath = String.format("%s://%s/",
Expand Down Expand Up @@ -1392,6 +1394,7 @@ public void testHSyncKeyOverwriteNormalKey() throws Exception {
}

@Test
@Unhealthy("HDDS-11870")
public void testHSyncKeyOverwriteHSyncKey() throws Exception {
// Set the fs.defaultFS
final String rootPath = String.format("%s://%s/",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,15 @@
import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
import org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB;
import org.apache.hadoop.util.Time;
import org.apache.ozone.test.tag.Unhealthy;
import org.junit.jupiter.api.Test;

import java.io.IOException;

/**
* Test class for quota repair.
*/
@Unhealthy("HDDS-11868")
public class TestQuotaRepairTask extends TestOMKeyRequest {

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
import org.apache.hadoop.security.token.Token;
import org.apache.hadoop.util.Time;

import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_RATIS_ENABLE_KEY;
import static org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMTokenProto.Type.S3AUTHINFO;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand All @@ -75,6 +74,7 @@

import org.slf4j.event.Level;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Unhealthy;
import org.apache.ratis.protocol.RaftPeerId;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
Expand Down Expand Up @@ -132,14 +132,6 @@ public void setUp() throws Exception {

private OzoneConfiguration createNewTestPath() throws IOException {
OzoneConfiguration config = new OzoneConfiguration();
// When ratis is enabled, tokens are not updated to the store directly by
// OzoneDelegationTokenSecretManager. Tokens are updated via Ratis
// through the DoubleBuffer. Hence, to test
// OzoneDelegationTokenSecretManager, we should disable OM Ratis.
// TODO: Once HA and non-HA code paths are merged in
// OzoneDelegationTokenSecretManager, this test should be updated to
// test both ratis enabled and disabled case.
config.setBoolean(OZONE_OM_RATIS_ENABLE_KEY, false);
File newFolder = folder.toFile();
if (!newFolder.exists()) {
assertTrue(newFolder.mkdirs());
Expand Down Expand Up @@ -268,11 +260,13 @@ private void testRenewTokenSuccessHelper(boolean restartSecretManager)
}

@Test
@Unhealthy("HDDS-11869")
public void testReloadAndRenewToken() throws Exception {
testRenewTokenSuccessHelper(true);
}

@Test
@Unhealthy("HDDS-11869")
public void testRenewTokenSuccess() throws Exception {
testRenewTokenSuccessHelper(false);
}
Expand All @@ -281,6 +275,7 @@ public void testRenewTokenSuccess() throws Exception {
* Tests failure for mismatch in renewer.
*/
@Test
@Unhealthy("HDDS-11869")
public void testRenewTokenFailure() throws Exception {
secretManager = createSecretManager(conf, TOKEN_MAX_LIFETIME,
expiryTime, TOKEN_REMOVER_SCAN_INTERVAL);
Expand Down Expand Up @@ -348,6 +343,7 @@ public void testCreateIdentifier() throws Exception {
}

@Test
@Unhealthy("HDDS-11869")
public void testCancelTokenSuccess() throws Exception {
secretManager = createSecretManager(conf, TOKEN_MAX_LIFETIME,
expiryTime, TOKEN_REMOVER_SCAN_INTERVAL);
Expand Down

0 comments on commit 34df4ed

Please sign in to comment.