Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the leftover dbg! call #53

Closed
shekohex opened this issue Nov 26, 2024 · 1 comment · Fixed by #54
Closed

remove the leftover dbg! call #53

shekohex opened this issue Nov 26, 2024 · 1 comment · Fixed by #54
Labels
enhancement New feature or request

Comments

@shekohex
Copy link
Contributor

There is an annoying dbg call here:
https://github.com/adrien-bon/bevy_ecs_tiled/blob/main/src%2Fasset.rs#L166-L167

This should be replaced by debug! or even better a trace! instead.

Happy to open a PR with this small chance.
@adrien-bon
Copy link
Owner

Hi!

Thanks for reporting the issue.

This dbg() call was added then forgotten during rework on properties.
Yes, please go ahead and remove it!

@adrien-bon adrien-bon added the enhancement New feature or request label Nov 27, 2024
shekohex added a commit to shekohex/bevy_ecs_tiled that referenced this issue Nov 28, 2024
@shekohex
Replace dbg! call with trace! in src/asset.rs
eab8212 
Fixes adrien-bon#53

* Replace the `dbg!` call with `trace!(?properties, "user properties")` to log the properties at the trace level.
@shekohex shekohex mentioned this issue Nov 28, 2024
Merged
adrien-bon pushed a commit that referenced this issue Dec 1, 2024
@shekohex
chore: Replace dbg! call with trace! in src/asset.rs (#54)
f84b4af 
* Replace dbg! call with trace! in src/asset.rs

Fixes #53

* Replace the `dbg!` call with `trace!(?properties, "user properties")` to log the properties at the trace level.

* chore: Add module documentation comment in asset.rs

* chore: Add logging section to debug guide

* chore: Update CHANGELOG for v0.4.2 changes

* lint: Simplify lifetime parameters in ResourceReader implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Replace dbg! call with trace! in src/asset.rs shekohex/bevy_ecs_tiled
2 participants
@shekohex @adrien-bon