Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace dbg! call with trace! in src/asset.rs #54

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

shekohex
Copy link
Contributor

Fixes #53

  • Replace the dbg! call with trace!(?properties, "user properties") to log the properties at the trace level.

Fixes adrien-bon#53

* Replace the `dbg!` call with `trace!(?properties, "user properties")` to log the properties at the trace level.
@shekohex shekohex changed the title Replace dbg! call with trace! in src/asset.rs chore: Replace dbg! call with trace! in src/asset.rs Nov 28, 2024
@shekohex shekohex marked this pull request as ready for review November 28, 2024 10:55
@adrien-bon
Copy link
Owner

Thanks for the PR!
Could you please also update the Changelog file + add a note about how to enable this trace in the dedicated book section ?

@shekohex
Copy link
Contributor Author

Sure thing!

@shekohex
Copy link
Contributor Author

Thanks for the PR! Could you please also update the Changelog file + add a note about how to enable this trace in the dedicated book section ?

Done @adrien-bon

@adrien-bon adrien-bon merged commit f84b4af into adrien-bon:main Dec 1, 2024
5 checks passed
@shekohex shekohex deleted the fix-dbg-call branch December 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the leftover dbg! call
2 participants