Skip to content

Commit

Permalink
anchors: Fix invalid YAML in aliases test cases
Browse files Browse the repository at this point in the history
Although accepted by PyYAML, `{*x: 4}` is not valid YAML: it should be
noted `{*x : 4}`. The reason is that a colon can be part of an anchor
name. See this comment from Tina Müller for more details:
#550 (comment)

Even if it's not a problem for yamllint, let's fix our tests to include
valid YAML snippets.
  • Loading branch information
adrienverge committed Apr 5, 2023
1 parent 6bfd675 commit e90e0a0
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions tests/rules/test_anchors.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def test_disabled(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &y 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &y 3, *x : 4, e: *y}\n'
'...\n', conf)
self.check('---\n'
'- &i 42\n'
Expand Down Expand Up @@ -74,7 +74,7 @@ def test_disabled(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &x 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &x 3, *x : 4, e: *y}\n'
'...\n', conf)

def test_forbid_undeclared_aliases(self):
Expand Down Expand Up @@ -106,7 +106,7 @@ def test_forbid_undeclared_aliases(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &y 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &y 3, *x : 4, e: *y}\n'
'...\n', conf)
self.check('---\n'
'- &i 42\n'
Expand Down Expand Up @@ -134,15 +134,15 @@ def test_forbid_undeclared_aliases(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &x 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &x 3, *x : 4, e: *y}\n'
'...\n', conf,
problem1=(9, 3),
problem2=(10, 3),
problem3=(11, 3),
problem4=(12, 3),
problem5=(13, 3),
problem6=(24, 7),
problem7=(27, 36))
problem7=(27, 37))

def test_forbid_duplicated_anchors(self):
conf = ('anchors:\n'
Expand Down Expand Up @@ -173,7 +173,7 @@ def test_forbid_duplicated_anchors(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &y 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &y 3, *x : 4, e: *y}\n'
'...\n', conf)
self.check('---\n'
'- &i 42\n'
Expand Down Expand Up @@ -201,7 +201,7 @@ def test_forbid_duplicated_anchors(self):
' <<: *b_m\n'
' foo: bar\n'
'---\n'
'{a: 1, &x b: 2, c: &x 3, *x: 4, e: *y}\n'
'{a: 1, &x b: 2, c: &x 3, *x : 4, e: *y}\n'
'...\n', conf,
problem1=(5, 3),
problem2=(6, 3),
Expand Down

0 comments on commit e90e0a0

Please sign in to comment.