From 63abef403f9f89defbc4f016bb8e8b1882485e35 Mon Sep 17 00:00:00 2001 From: aegilops <41705651+aegilops@users.noreply.github.com> Date: Tue, 18 Nov 2025 17:42:41 +0000 Subject: [PATCH 1/2] Specific error handling for float errors --- enrich_code_scanning_alerts.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/enrich_code_scanning_alerts.py b/enrich_code_scanning_alerts.py index 38f7735..eae7cd9 100755 --- a/enrich_code_scanning_alerts.py +++ b/enrich_code_scanning_alerts.py @@ -16,7 +16,6 @@ from typing import Any from pathlib import Path from datetime import datetime, timezone -import time from mistletoe import markdown import humanize from defusedcsv import csv @@ -60,7 +59,7 @@ def fixup_rule_metadata_codeql(rule_metadata: dict) -> None: rule_metadata["security-severity"] = float( rule_metadata["security-severity"] ) - except: + except (FloatingPointError, ValueError): LOG.warning( "Could not parse security-severity in rule %s as float: %s", rule_metadata.get("id", "unknown ID"), From 39ad44e5e898136d8d20607517891333e571d87a Mon Sep 17 00:00:00 2001 From: aegilops <41705651+aegilops@users.noreply.github.com> Date: Tue, 18 Nov 2025 17:45:30 +0000 Subject: [PATCH 2/2] Correct implicit return --- list_secret_scanning_alerts.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/list_secret_scanning_alerts.py b/list_secret_scanning_alerts.py index ec1c815..e428cca 100755 --- a/list_secret_scanning_alerts.py +++ b/list_secret_scanning_alerts.py @@ -242,14 +242,16 @@ def list_secret_scanning_alerts( alerts = decorate_alerts(g, alerts, include_locations=include_locations, include_commit=include_commit) if raw: - return alerts + for alert in alerts: + yield alert + return None else: for alert in alerts: result = make_result(g, alert, scope, name, include_secret=include_secret, include_locations=include_locations, include_commit=include_commit) if result is not None: yield result else: - return + return None def add_args(parser: argparse.ArgumentParser) -> None: