Add events for image uploads #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roelofr
requested changes
Jul 12, 2023
roelofr
reviewed
Jul 12, 2023
|
Thanks for your comments. I will update this pr this week! |
Co-authored-by: Roelof <github@roelofr.dev>
|
I am unsure why the v8 tests keep failing. Running them locally produces no such errors. |
|
@roelofr Alright, everything seems to be good now |
roelofr
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Hey, thanks for picking this back up after the pipelines were fixed.
As time moves on, so does my understanding of code, It seems like a good idea to remove unused traits, but other than that it looks ready to roll.
Please add a CHANGELOG entry so we can keep track of these changes, then we'll get this merged in.
Co-authored-by: Roelof <github@roelofr.dev>
Co-authored-by: Roelof <github@roelofr.dev>
roelofr
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds events for image uploads and thumbnail generation. This allows users to hook into these processes. I for instance want to convert uploaded images to webp, and use the OG image as fallback. With these events I can now just listen for uploads and dispatch conversion jobs.
I'm sure there are many other things people will be able to do with this feature.
Resolves #84