Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make materialisation of columns optional for the library extract query. #1437

Open
piotrszul opened this issue May 8, 2023 · 0 comments
Open
Assignees
Labels
new feature New feature or request
Milestone

Comments

@piotrszul
Copy link
Collaborator

Currently the extract operation performs materialisation of extracted columns (that is conversion to the corresponding literals).
This is a desirable behaviour for the FHIR API extract operation, when the values of for the columns should be simple values representable in CSV format, but it puts a limitation on the types of columns that can be extracted.

For the library API hover the result of extract is a dataset, in which any type can be represented, so this constraint is not necessary.

The API should allow the user to extract any columns they want and preserve the original types of these columns. (In particular currently DATETIME (TIMESTAMP) columns are converted to STRING columns).

The API should allow the user to optionally request materialisation.

Additionally the users should have an option to materialise selected columns by adding type conversion (e.g. to STRING) these columns.

@piotrszul piotrszul added the new feature New feature or request label May 8, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Pathling May 8, 2023
@piotrszul piotrszul removed the status in Pathling May 8, 2023
@piotrszul piotrszul moved this to Backlog in Pathling May 8, 2023
@piotrszul piotrszul self-assigned this May 8, 2023
@piotrszul piotrszul added this to the v6.2.0 milestone May 8, 2023
@johngrimes johngrimes removed this from the v6.2.0 milestone May 28, 2023
@johngrimes johngrimes assigned johngrimes and unassigned piotrszul Jun 26, 2023
@johngrimes johngrimes moved this from Backlog to In progress in Pathling Jun 26, 2023
@johngrimes johngrimes added this to the SQL on FHIR Views milestone Jul 6, 2023
@johngrimes johngrimes assigned piotrszul and unassigned johngrimes Aug 22, 2023
@johngrimes johngrimes assigned johngrimes and unassigned piotrszul Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: In progress
Development

No branches or pull requests

2 participants