Implementing full encoding and decoding support for References #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncludes the 'identifier' fields with 0 level nesting ('assigner' removed from Identifiers used in references).
johngrimes
added
new feature
johngrimes
requested changes
Apr 10, 2024
There was a problem hiding this comment.
I don't seem to be able to traverse into identifier within a Reference within the context of a FHIRPath query, even though this field has been encoded in the schema.
data.extract("Condition", ["id", "subject.identifier.value"])Would you mind giving this a go and seeing if you can reproduce?
(removing the special case implementation)
|
This is the error that occurs if you try to traverse to I think this is fine for now. |
johngrimes
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Thanks @piotrszul! The traversal problem is now fixed for me.
I've added a few further items of feedback.
encoders/src/main/scala/au/csiro/pathling/encoders/SerializerBuilder.scala
Show resolved
Hide resolved
fhir-server/src/test/java/au/csiro/pathling/fhirpath/parser/ParserTest.java
Show resolved
Hide resolved
fhirpath/src/test/java/au/csiro/pathling/fhirpath/parser/FhirpathTest.java
Outdated
Show resolved
Hide resolved
johngrimes
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1784