Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying externalIPs for ingress-nginx #164

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Allow specifying externalIPs for ingress-nginx #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/extra/ingress/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ name: ingress
description: NGINX Ingress Controller
icon: https://docs.nginx.com/nginx-ingress-controller/images/icons/NGINX-Ingress-Controller-product-icon.svg
type: application
version: 1.0.0
version: 1.1.0
7 changes: 4 additions & 3 deletions packages/extra/ingress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Common parameters

| Name | Description | Value |
| ---------- | -------------------------------- | ----- |
| `replicas` | Number of ingress-nginx replicas | `2` |
| Name | Description | Value |
| ------------- | -------------------------------- | ----- |
| `replicas` | Number of ingress-nginx replicas | `2` |
| `externalIPs` | List of externalIPs for service. | `[]` |
23 changes: 23 additions & 0 deletions packages/extra/ingress/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"comments": {
"format": "##"
},
"tags": {
"param": "@param",
"section": "@section",
"descriptionStart": "@descriptionStart",
"descriptionEnd": "@descriptionEnd",
"skip": "@skip",
"extra": "@extra"
},
"modifiers": {
"array": "array",
"object": "object",
"string": "string",
"nullable": "nullable",
"default": "default"
},
"regexp": {
"paramsSectionTitle": "Parameters"
}
}
10 changes: 10 additions & 0 deletions packages/extra/ingress/templates/nginx-ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,13 @@ spec:
admissionWebhooks:
enabled: false
{{- end }}
service:
{{- if .Values.externalIPs }}
externalIPs:
{{- toYaml .Values.externalIPs | nindent 12 }}
type: ClusterIP
externalTrafficPolicy: Cluster
{{- else }}
type: LoadBalancer
externalTrafficPolicy: Local
{{- end }}
8 changes: 8 additions & 0 deletions packages/extra/ingress/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
"type": "number",
"description": "Number of ingress-nginx replicas",
"default": 2
},
"externalIPs": {
"type": "array",
"description": "List of externalIPs for service.",
"default": "[]",
"items": {
"type": "string"
}
}
}
}
11 changes: 11 additions & 0 deletions packages/extra/ingress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,14 @@
## @param replicas Number of ingress-nginx replicas
##
replicas: 2

## @param externalIPs [array] List of externalIPs for service.
## Optional. If not specified will use LoadBalancer service by default.
##
## e.g:
## externalIPs:
## - "11.22.33.44"
## - "11.22.33.45"
## - "11.22.33.46"
##
externalIPs: []
3 changes: 2 additions & 1 deletion packages/extra/versions_map
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ etcd 1.0.0 f7eaab0
etcd 2.0.0 a6d0f7cf
etcd 2.0.1 6fc1cc7d
etcd 2.1.0 HEAD
ingress 1.0.0 HEAD
ingress 1.0.0 f642698
ingress 1.1.0 HEAD
monitoring 1.0.0 HEAD