-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Flux 2.3.x #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
we need to conform to the current version in use, 2.2.x, but otherwise we don't need to specify all of this, and as long as we don't specify any of this, then user can merge their own configs in with kubectl apply I hope the FluxInstance registry is set to default to ghcr, so we don't block anyone from using an enterprise or paid distribution of flux with this config! Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
spec.distribution.registry: Required value (drat!) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
This reverts commit 4989e01.
the chart installs by default all 6 components, so make sure we are taking them all over this way Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
You can verify that everything upgraded successfully with |
kvaps
reviewed
Jun 15, 2024
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
IDK Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
it's tested now, it works, we know where the failures are (and they aren't a problem for now) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
1 task
kingdonb
force-pushed
the
flux-2.3
branch
2 times, most recently
from
June 16, 2024 02:49
af6d7ae
to
2154617
Compare
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
HelmRelease is v2 and HelmRepository is v1 now, as of Flux 2.3 Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Helm Controller is GA as of Flux 2.3 Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
this change was the real motivation for introducing flux-operator +fixup Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
so users can override it (we should probably provide a way to disable these customizations as well, so they can provide their own without getting clobbered by cozystack-installer) As we know there is no simple way to perform array merges in Helm values Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
this caused an error Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
kingdonb
added a commit
to kingdonb/cozystack
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com> Co-authored-by: Andrei Kvapil <kvapss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in #166 this was super easy. I don't think there were any errors, and I think the installer would have quit if anything errored out, but I'm going to read the cozystack-installer logs carefully just to be sure we got all the deprecated references. There were some more than I thought of initially.
This PR includes #166
and should probably be rebased again before merging, after that one it can be merged. (Or, alternatively, I guess you could merge both at once.)