TASK: Neos >7 compatibility #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjwnc This has the desired effect and the module works again. However, I still get an error in the JS console: |
Yes, I think with Neos 7 some JS libraries (bootstrap / jquery) are droped by default for the backend. I'm not that sure, because I'm not that into frontend dev. Maybe require-js or something is missing. I had a discussion about this with @markusguenther in slack quite some time ago. You can search for this PR or My goal was to make it work again now, because this package might get into the core sometime in the unforeseeable future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the release of NEOS 7.x the load more button doesn't work because I think the backend UI dropped the default loading of jquery. With this fix the filters and load more button works with NEOS 7 and 8.
This fix was mentioned by @markusguenther during a slack discussion about this issue.
There is still a js error in the backend related to the popup's because require.js is not available anymore, but at least the main feature is working again.