Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wip) Replace http compiler calls with calldata en/decode lib for contract calls #1259

Closed
wants to merge 6 commits into from

Conversation

mradkov
Copy link
Contributor

@mradkov mradkov commented Jul 16, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request introduces 1 alert when merging ecb793b into 99f26eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@mradkov mradkov force-pushed the feature/experimental-calldata branch from c77786f to cb156f1 Compare July 21, 2021 10:17
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request introduces 1 alert when merging cb156f1 into 99f26eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2021

This pull request introduces 1 alert when merging 1e6441b into 99f26eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2021

This pull request introduces 1 alert when merging 24abd31 into 99f26eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@mradkov mradkov force-pushed the feature/experimental-calldata branch from 24abd31 to 54b0182 Compare July 28, 2021 12:31
@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2021

This pull request introduces 1 alert when merging 54b0182 into 99f26eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@mradkov mradkov force-pushed the feature/experimental-calldata branch 5 times, most recently from 58d76a2 to 31034dd Compare August 10, 2021 15:15
@mradkov mradkov changed the title wip: add calldata lib (wip) Replace http compiler calls with calldata encode/decode lib for contract calls Aug 10, 2021
@mradkov mradkov changed the title (wip) Replace http compiler calls with calldata encode/decode lib for contract calls (wip) Replace http compiler calls with calldata en/decode lib for contract calls Aug 10, 2021
@mradkov mradkov force-pushed the feature/experimental-calldata branch from 31034dd to 229d891 Compare September 7, 2021 14:33
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #1259 (c7e5fd6) into develop (9b70f8e) will decrease coverage by 14.99%.
The diff coverage is 100.00%.

❗ Current head c7e5fd6 differs from pull request most recent head 5fbe363. Consider uploading reports for the commit 5fbe363 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1259       +/-   ##
============================================
- Coverage    62.70%   47.70%   -15.00%     
============================================
  Files           56       56               
  Lines         2574     2595       +21     
  Branches        36       36               
============================================
- Hits          1614     1238      -376     
- Misses         953     1349      +396     
- Partials         7        8        +1     
Impacted Files Coverage Δ
src/contract/compiler.js 96.07% <100.00%> (+27.78%) ⬆️
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 11.01% <0.00%> (-88.14%) ⬇️
.../utils/aepp-wallet-communication/rpc/rpc-client.js 7.01% <0.00%> (-87.72%) ⬇️
...rc/utils/aepp-wallet-communication/rpc/aepp-rpc.js 16.12% <0.00%> (-83.88%) ⬇️
src/ae/oracle.js 17.39% <0.00%> (-82.61%) ⬇️
...communication/connection/browser-window-message.js 14.58% <0.00%> (-75.00%) ⬇️
src/ae/aens.js 29.78% <0.00%> (-70.22%) ⬇️
src/contract/ga/index.js 30.43% <0.00%> (-69.57%) ⬇️
src/utils/aepp-wallet-communication/helpers.js 34.37% <0.00%> (-65.63%) ⬇️
src/tx/tx.js 48.27% <0.00%> (-36.79%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34f18b...5fbe363. Read the comment docs.

@subhod-i
Copy link
Contributor

@mradkov Do we still need the ae-compiler service in the docker-compose file once calldata lib implemented?

@marc0olo
Copy link
Contributor

@mradkov Do we still need the ae-compiler service in the docker-compose file once calldata lib implemented?

yes for actually compiling the contract it is still required. the calldata-lib will enable us to encode/decode the contract calls.

@mradkov mradkov requested a review from davidyuk October 12, 2021 08:48
@marc0olo marc0olo assigned mradkov and davidyuk and unassigned mradkov Oct 12, 2021
@mradkov mradkov force-pushed the feature/experimental-calldata branch from 771a422 to 5fbe363 Compare October 14, 2021 08:27
@davidyuk
Copy link
Member

replaced by #1313

@davidyuk davidyuk closed this Oct 27, 2021
@davidyuk davidyuk deleted the feature/experimental-calldata branch November 19, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants