-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(wip) Replace http compiler calls with calldata en/decode lib for contract calls #1259
Conversation
This pull request introduces 1 alert when merging ecb793b into 99f26eb - view on LGTM.com new alerts:
|
c77786f
to
cb156f1
Compare
This pull request introduces 1 alert when merging cb156f1 into 99f26eb - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1e6441b into 99f26eb - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 24abd31 into 99f26eb - view on LGTM.com new alerts:
|
24abd31
to
54b0182
Compare
This pull request introduces 1 alert when merging 54b0182 into 99f26eb - view on LGTM.com new alerts:
|
58d76a2
to
31034dd
Compare
31034dd
to
229d891
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1259 +/- ##
============================================
- Coverage 62.70% 47.70% -15.00%
============================================
Files 56 56
Lines 2574 2595 +21
Branches 36 36
============================================
- Hits 1614 1238 -376
- Misses 953 1349 +396
- Partials 7 8 +1
Continue to review full report at Codecov.
|
229d891
to
f7c4a7e
Compare
cd19b65
to
6489b0a
Compare
6489b0a
to
771a422
Compare
@mradkov Do we still need the ae-compiler service in the docker-compose file once calldata lib implemented? |
yes for actually compiling the contract it is still required. the calldata-lib will enable us to encode/decode the contract calls. |
…piler for encoding contractCall
771a422
to
5fbe363
Compare
replaced by #1313 |
No description provided.