From 9b8f086212a3076c7ac6a11d0bafd4cef553c7ea Mon Sep 17 00:00:00 2001
From: Josef Reidinger <jreidinger@suse.cz>
Date: Thu, 14 Dec 2023 13:49:45 +0100
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Martin Vidner <mvidner@suse.cz>
---
 doc/dbus/org.opensuse.Agama.Software1.doc.xml | 2 +-
 rust/agama-lib/src/error.rs                   | 2 +-
 rust/package/agama-cli.changes                | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/dbus/org.opensuse.Agama.Software1.doc.xml b/doc/dbus/org.opensuse.Agama.Software1.doc.xml
index 9cc325862a..ed2dca4c0f 100644
--- a/doc/dbus/org.opensuse.Agama.Software1.doc.xml
+++ b/doc/dbus/org.opensuse.Agama.Software1.doc.xml
@@ -54,7 +54,7 @@
       <arg name="result" direction="out" type="b"/>
     </method>
     <!--
-      Sets explicitelly selected patterns.
+      Sets explicitly selected patterns.
     -->
     <method name="SetUserPatterns">
       <!--
diff --git a/rust/agama-lib/src/error.rs b/rust/agama-lib/src/error.rs
index 19002179b3..b1fc9ba579 100644
--- a/rust/agama-lib/src/error.rs
+++ b/rust/agama-lib/src/error.rs
@@ -18,7 +18,7 @@ pub enum ServiceError {
     WrongUser(Vec<String>),
     #[error("Registration failed: '{0}'")]
     FailedRegistration(String),
-    #[error("Failed to find these patterns: '{0:?}'")]
+    #[error("Failed to find these patterns: {0:?}")]
     UnknownPatterns(Vec<String>),
     #[error("Error: {0}")]
     UnsuccessfulAction(String),
diff --git a/rust/package/agama-cli.changes b/rust/package/agama-cli.changes
index ee76c4e5b9..481dd38dc0 100644
--- a/rust/package/agama-cli.changes
+++ b/rust/package/agama-cli.changes
@@ -6,6 +6,7 @@ Fri Dec  8 09:23:09 UTC 2023 - Josef Reidinger <jreidinger@suse.com>
   2. in product section is now also registrationCode and registrationEmail
   3. in software section is now patterns to select patterns to install
 - adapt profile.schema according to above changes
+- org.opensuse.Agama.Software1 API changed to report missing patterns
 
 -------------------------------------------------------------------
 Tue Dec  5 11:18:41 UTC 2023 - Jorik Cronenberg <jorik.cronenberg@suse.com>