diff --git a/web/package/cockpit-agama.changes b/web/package/cockpit-agama.changes index 9c112b90b8..4605122b18 100644 --- a/web/package/cockpit-agama.changes +++ b/web/package/cockpit-agama.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Mon Apr 8 14:17:45 UTC 2024 - José Iván López González + +- Improve the representation of the devices in the dialog for + finding space (gh#openSUSE/agama#1128). + ------------------------------------------------------------------- Thu Apr 4 15:59:37 UTC 2024 - Ancor Gonzalez Sosa diff --git a/web/src/assets/styles/blocks.scss b/web/src/assets/styles/blocks.scss index 50b32062af..7b4bd2874e 100644 --- a/web/src/assets/styles/blocks.scss +++ b/web/src/assets/styles/blocks.scss @@ -526,9 +526,7 @@ table[data-type="agama/tree-table"] { } } -// FIXME: use a single selector -table.devices-table, -table.proposal-result { +table.devices-table { tr.dimmed-row { background-color: #fff; opacity: 0.8; @@ -538,8 +536,11 @@ table.proposal-result { color: var(--color-gray-dimmed); padding-block: 0; } - } +} + +table.proposal-result { + @extend .devices-table; /** * Temporary hack because the collapse/expand callback was not given to the diff --git a/web/src/components/core/OptionsPicker.jsx b/web/src/components/core/OptionsPicker.jsx index 55cc44f850..eb1d96f011 100644 --- a/web/src/components/core/OptionsPicker.jsx +++ b/web/src/components/core/OptionsPicker.jsx @@ -19,8 +19,12 @@ * find current contact information at www.suse.com. */ +// @ts-check + import React from "react"; +import { noop } from "~/utils"; + /** * Wrapper for OptionsPicker options * @component @@ -29,12 +33,14 @@ import React from "react"; * @param {string} [props.title] - Text to be used as option title * @param {string} [props.body] - Text to be used as option body * @param {boolean} [props.isSelected=false] - Whether the option should be set as select of not + * @param {() => void} [props.onClick=noop] * @param {object} [props.props] - Other props sent to div#option node */ -const Option = ({ title, body, isSelected = false, ...props }) => { +const Option = ({ title, body, isSelected = false, onClick = noop, ...props }) => { return (
@@ -50,10 +56,10 @@ const Option = ({ title, body, isSelected = false, ...props }) => { * * @param {object} props * @param {string} [props.ariaLabel] - Text to be used as accessible label - * @param {Array