Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact shapes classes DiagramKind #14

Open
amivanoff opened this issue Apr 2, 2021 · 1 comment
Open

Compact shapes classes DiagramKind #14

amivanoff opened this issue Apr 2, 2021 · 1 comment

Comments

@amivanoff
Copy link
Member

  • No separate top-level PropertyShape nodes, only NodeShape nodes are top-level
  • All simple-type PropertyShapes (string, int,.. all except IRI) are like UML class properties (in compartments in Class nodes)
  • Arrow types
    • Class inheritance relation (class-to-superclass) -- arrow between NodeShapes based on relation between their targetClass classes
    • Class reference relation (classA-to-classB-by-propertyC) -- arrow between shapes if there is a PropertyShape in class A with sh:nodeKind = sh:IRI and sh:class = iri of class B. Arrow label = propertyC IRI
@Mvwivs
Copy link
Contributor

Mvwivs commented Apr 2, 2021

Actually change from #13

now user is not forced to pass parentId explicitly during node view implementation: parentId is passed to children with useContext (context uses nearest provided value and thus nearest parent)

doesn't allow to create separate [IRI] PropertyShape nodes from some "current" node (parent id is passed implicitly with context, so created shapes always become children of the "current" one). Reverting back to previous approach with passing parent id explicitly as prop should resolve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants