-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGID Index Validation #2692
Merged
Merged
SGID Index Validation #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gis-utah ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stdavis
force-pushed
the
feat/sgid-index-validation
branch
2 times, most recently
from
March 22, 2024 22:27
c44c6ef
to
443d382
Compare
stdavis
force-pushed
the
feat/sgid-index-validation
branch
from
March 22, 2024 22:44
67212dc
to
0461026
Compare
Can we add the download metadata ts file to this check also? Making sure the value are the same yada yada |
❌ Deploy Preview for gis-utah-gov failed.
|
stdavis
force-pushed
the
feat/sgid-index-validation
branch
from
March 25, 2024 21:12
4290150
to
b9e679d
Compare
stdavis
force-pushed
the
feat/sgid-index-validation
branch
from
March 25, 2024 21:30
98ed2d0
to
6c7e9b6
Compare
steveoh
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script for validating the SGID Index Spreadsheet and an associated scheduled action.
The validation script does the following checks:
openSgidTableName
field against the OpenSGID databaseproductPage
value to make sure that it's a valid internal path or external URL (including verifying that a hub link is actually finding the item)id
guidsitemId
to update the following columns:hubName
,hubOrganization
,serverHost
,serverServiceName
openSgidTableName
,itemId
,id
,displayName
src/data/downloadMetadata.ts
:If the script finds any errors, the workflow opens a new issue. Here's an example: #2694
Some questions:
productPageValidation
column anymore?displayName
column be updated to matchhubName
if it exists?TODO:
issue_comment
event that looks for slash commands to allow users to rerun the validationpush
event from the new workflow once this is ready for merge.https://gis-utah.netlify.app
for productPagePage validationFYIs:
Closes #2688