Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link testing workflow for linkedin #44

Closed
vivalareda opened this issue Nov 29, 2023 · 3 comments
Closed

Fix link testing workflow for linkedin #44

vivalareda opened this issue Nov 29, 2023 · 3 comments

Comments

@vivalareda
Copy link
Contributor

Linkedin doesn't allow http request from bots and returns a status code of 999, either we need to exclude linkedin links or mark status code 999 as valid links (both case wouldn't test link just not make the whole workflow fail)

vivalareda added a commit that referenced this issue Nov 29, 2023
vivalareda added a commit that referenced this issue Nov 29, 2023
vivalareda added a commit that referenced this issue Nov 29, 2023
vivalareda added a commit that referenced this issue Nov 29, 2023
@rngadam
Copy link
Contributor

rngadam commented Nov 29, 2023

999 should be considered valid; it's an HTTP code returned by a webserver, so likely the link has content valid just not content accessible by the bot.

https://http.dev/999

@vivalareda
Copy link
Contributor Author

this is fixed by adding the config file to the calling workflow as can be seen here
https://github.com/ai-cfia/dev-rel-docs/actions/runs/7046613604/job/19178762760

@vivalareda vivalareda reopened this Nov 30, 2023
vivalareda added a commit that referenced this issue Nov 30, 2023
@vivalareda
Copy link
Contributor Author

this is fixed by adding the config file to the calling workflow as can be seen here https://github.com/ai-cfia/dev-rel-docs/actions/runs/7046613604/job/19178762760

Reopenned to add the input to pass the name of the config file when calling the workflow

vivalareda added a commit that referenced this issue Dec 2, 2023
author redat97 <tarzaltreda@gmail.com> 1701207315 -0500
committer redat97 <tarzaltreda@gmail.com> 1701538990 -0500

issue #43: add line 80 check, config and update doc

issue #45 #43: add link testing and markdown lint

issue #43: config file not needed

issue #43: no config file

issue #43: add new config file

issue #43: rename config file

issue #43: test workflow

issue #49: test wrap

issue #43: test wrap

issue #43: test wrap

issue #43: test workflow

issue #44: ignore pattern

issue #44: change config to config-file

issue #44: change pattern and move condition

issue #44: update config

issue #44: modify config file

issue #44: update config

issue #43: update config file

issue #43: update config file

issue #43: update config file

issue #43: add config input

issue #43: move inputs

add ls

remove show files

issue #44: fix automatically

issue #43: change name

remove config files

issue #43: run markdown on push and rm config

fix trigger
vivalareda added a commit that referenced this issue Dec 2, 2023
author redat97 <tarzaltreda@gmail.com> 1701207315 -0500
committer redat97 <tarzaltreda@gmail.com> 1701540145 -0500

parent 71dad0c
author redat97 <tarzaltreda@gmail.com> 1701207315 -0500
committer redat97 <tarzaltreda@gmail.com> 1701539610 -0500

parent 71dad0c
author redat97 <tarzaltreda@gmail.com> 1701207315 -0500
committer redat97 <tarzaltreda@gmail.com> 1701538990 -0500

issue #43: add line 80 check, config and update doc

issue #45 #43: add link testing and markdown lint

issue #43: config file not needed

issue #43: no config file

issue #43: add new config file

issue #43: rename config file

issue #43: test workflow

issue #49: test wrap

issue #43: test wrap

issue #43: test wrap

issue #43: test workflow

issue #44: ignore pattern

issue #44: change config to config-file

issue #44: change pattern and move condition

issue #44: update config

issue #44: modify config file

issue #44: update config

issue #43: update config file

issue #43: update config file

issue #43: update config file

issue #43: add config input

issue #43: move inputs

add ls

remove show files

issue #44: fix automatically

issue #43: change name

remove config files

issue #43: run markdown on push and rm config

fix trigger

issue #43: add line 80 check, config and update doc

issue #45 #43: add link testing and markdown lint

issue #43: config file not needed

issue #43: add new config file

issue #43: rename config file

issue #43: test workflow

issue #49: test wrap

issue #43: test wrap

issue #43: test wrap

issue #43: test workflow

issue #44: ignore pattern

issue #44: change config to config-file

issue #44: change pattern and move condition

issue #44: update config

issue #44: modify config file

issue #44: update config

issue #43: update config file

issue #43: update config file

issue #43: update config file

issue #43: add config input

issue #43: move inputs

add ls

remove show files

issue #43: change name

remove config files

issue #43: run markdown on push and rm config

fix trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants