Skip to content

Commit 1f03876

Browse files
committed
nit: update comments and use uv cache for pip install if applicable
1 parent a3d0af5 commit 1f03876

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

container/Dockerfile.sglang

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,10 @@ RUN apt-get update && \
431431

432432
# Install SGLang and related packages (sgl-kernel, einops, sentencepiece) since they are not included in the runtime wheel
433433
# https://github.com/sgl-project/sglang/blob/v0.4.9.post1/python/pyproject.toml#L18-51
434+
# This commit references the 0.4.9.post1 release which includes a NIXL fix that was released after the 0.4.8.post1 release https://github.com/sgl-project/sglang/pull/7330
434435
ARG SGLANG_COMMIT="066f4ec91f7becd1d490745c856c4a57ede9d1ca"
435-
RUN uv pip install "sglang[runtime_common]>=0.4.9.post1" einops sgl-kernel==0.2.4 sentencepiece
436+
RUN --mount=type=cache,target=/root/.cache/uv \
437+
uv pip install "sglang[runtime_common]==0.4.9.post1" einops sgl-kernel==0.2.4 sentencepiece
436438

437439
# Install the wheels and symlink executables to /usr/local/bin so dynamo components can use them
438440
# Dynamo components currently do not have the VIRTUAL_ENV in their PATH, so we need to symlink the executables
@@ -448,7 +450,7 @@ RUN --mount=type=bind,source=./container/launch_message.txt,target=/workspace/la
448450
sed '/^#\s/d' /workspace/launch_message.txt > ~/.launch_screen && \
449451
echo "cat ~/.launch_screen" >> ~/.bashrc
450452

451-
# Copy benchmarks, examples, tests and attribution files
453+
# Copy benchmarks, examples, and tests for CI
452454
# TODO: Remove this once we have a functional CI image built on top of the runtime image
453455
COPY tests /workspace/tests
454456
COPY benchmarks /workspace/benchmarks

0 commit comments

Comments
 (0)