Skip to content

Commit b445425

Browse files
authored
build: default to using dev instead of local-dev for vllm build (#2837)
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
1 parent 304dbb2 commit b445425

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.devcontainer/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn
9191

9292
### Step 1: Build the Development Container Image
9393

94-
Build `dynamo:latest-vllm-local-dev` from scratch from the source:
95-
- Note that currently, `local-dev` is only implemented for `--framework VLLM`.
94+
Build `dynamo:latest-vllm` from scratch from the source:
9695

9796
```bash
98-
./container/build.sh --target local-dev --framework VLLM
97+
./container/build.sh --target dev --framework VLLM
9998
```
10099

101100
The container will be built and give certain file permissions to your local uid and gid.

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"name": "NVIDIA Dynamo Dev Container Development",
88
"remoteUser": "ubuntu", // Matches our container user
99
"updateRemoteUserUID": true, // Updates the UID of the remote user to match the host user, avoids permission errors
10-
"image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM local dev image
10+
"image": "dynamo:latest-vllm", // Use the latest VLLM local dev image
1111
"runArgs": [
1212
"--gpus=all",
1313
"--network=host",

container/Dockerfile.vllm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ CMD []
294294
# Use this stage when you need a full development environment with additional
295295
# tooling beyond the base runtime image.
296296

297-
FROM runtime AS local-dev
297+
FROM runtime AS dev
298298

299299
# Install utilities
300300
RUN apt-get update -y && \

container/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ fi
465465
# Add NIXL_REF as a build argument
466466
BUILD_ARGS+=" --build-arg NIXL_REF=${NIXL_REF} "
467467

468-
if [[ $TARGET == "local-dev" ]]; then
468+
if [[ $TARGET == "dev" ]]; then
469469
BUILD_ARGS+=" --build-arg USER_UID=$(id -u) --build-arg USER_GID=$(id -g) "
470470
fi
471471

0 commit comments

Comments
 (0)