Skip to content

Commit b466983

Browse files
nv-anantsnnshah1Neelay Shah
authored
test: fix vllm multi GPU tests (#1923)
Signed-off-by: Neelay Shah <neelays@nvidia.com> Co-authored-by: Neelay Shah <neelays@nvidia.com> Co-authored-by: Neelay Shah <neelays@a4u8g-0057.ipp2u2.colossus.nvidia.com>
1 parent 6d19e0d commit b466983

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

tests/serve/test_dynamo_serve.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,29 +265,25 @@ def __init__(
265265
if graph.config:
266266
command.extend(["-f", os.path.join(graph.directory, graph.config)])
267267

268-
command.extend(["--Frontend.port", str(port)])
269-
270268
if args:
271269
for k, v in args.items():
272270
command.extend([f"{k}", f"{v}"])
273271

274272
health_check_urls = []
275273
health_check_ports = []
274+
env = None
276275

277276
# Handle multimodal deployments differently
278277
if "multimodal" in graph.directory:
279-
# Set DYNAMO_PORT environment variable for multimodal
280278
env = os.environ.copy()
281279
env["DYNAMO_PORT"] = str(port)
282-
# Don't add health check on port since multimodal uses DYNAMO_PORT
283280
else:
284281
# Regular LLM deployments
285282
command.extend(["--Frontend.port", str(port)])
286283
health_check_urls = [
287284
(f"http://localhost:{port}/v1/models", self._check_model)
288285
]
289286
health_check_ports = [port]
290-
env = None
291287

292288
self.port = port
293289
self.graph = graph
@@ -307,7 +303,7 @@ def __init__(
307303
"from multiprocessing.spawn",
308304
],
309305
log_dir=request.node.name,
310-
env=env, # Pass the environment variables
306+
env=env,
311307
)
312308

313309
def _check_model(self, response):

0 commit comments

Comments
 (0)