Skip to content

Conversation

@atchernych
Copy link
Contributor

@atchernych atchernych commented May 26, 2025

chore: Add user to dynamo deploy codeowners

Overview:
add atchernych to dynamo deploy codeowners

Details:
add atchernych to dynamo deploy codeowners

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated code ownership for deployment and example directories.

chore: Add user to dynamo deploy codeowners

Overview:
add atchernych to dynamo deploy codeowners

Details:
add atchernych to dynamo deploy codeowners
@atchernych atchernych requested review from a team and nnshah1 as code owners May 26, 2025 23:54
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the chore label May 26, 2025
@github-actions
Copy link

👋 Hi AnnaTchernych! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label May 26, 2025
AnnaTchernych

Signed-off-by: AnnaTchernych <atchernych@nvidia.com>
Signed-off-by: atchernych <atchernych@nvidia.com>
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 28, 2025

Walkthrough

The CODEOWNERS file was updated to include the user @atchernych as a code owner for the /deploy/ and /examples/ directories, in addition to the existing owners. No other changes were made to ownership assignments or directory paths.

Changes

File(s) Change Summary
CODEOWNERS Added @atchernych as code owner for /deploy/ and /examples/.

Possibly related PRs

Suggested reviewers

  • nnshah1

Poem

In the garden of CODEOWNERS, a new name appears,
@atchernych hops in, bringing cheers!
For /deploy/ and /examples/, the watch is now shared,
With diligent care, the code is prepared.
🐇✨
Welcome aboard, let’s keep the carrots paired!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
CODEOWNERS (1)

20-20: Owner list is growing unmanageably & contains duplicates – time to refactor

@biswapanda appears twice and the ever-lengthening line is hard to reason about.
Consider:

  1. Deduplicate the list.
  2. Split ownership into more specific sub-paths under /examples/ (e.g. /examples/llama2/, /examples/multimodal/, etc.) instead of one mega-line.
  3. Keep owner handles in a consistent order (alphabetical or team-first).

Example quick fix for the duplication:

-/examples/ @hutm @biswapanda @ishandhanani ... @biswapanda ... @atchernych @ai-dynamo/Devops
+/examples/ @hutm @biswapanda @ishandhanani ... @atchernych @ai-dynamo/Devops

A more thorough clean-up can be tackled in a follow-up PR.

🧹 Nitpick comments (1)
CODEOWNERS (1)

17-17: Addition looks fine, but keep the owner list alphabetised for readability

No functional problems, but since the list is growing it would help future readers if the handles were kept in alphabetical order (or another deterministic ordering).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d9aac7 and 609b13b.

📒 Files selected for processing (1)
  • CODEOWNERS (1 hunks)

@github-actions github-actions bot removed the Stale label Jun 29, 2025
@grahamking
Copy link
Contributor

Done in #1926

@grahamking grahamking closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore external-contribution Pull request is from an external contributor size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants