-
Notifications
You must be signed in to change notification settings - Fork 686
chore: Add user to dynamo deploy codeowners #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: Add user to dynamo deploy codeowners Overview: add atchernych to dynamo deploy codeowners Details: add atchernych to dynamo deploy codeowners
|
👋 Hi AnnaTchernych! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
AnnaTchernych Signed-off-by: AnnaTchernych <atchernych@nvidia.com>
Signed-off-by: atchernych <atchernych@nvidia.com>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
WalkthroughThe CODEOWNERS file was updated to include the user Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
CODEOWNERS (1)
20-20: Owner list is growing unmanageably & contains duplicates – time to refactor
@biswapandaappears twice and the ever-lengthening line is hard to reason about.
Consider:
- Deduplicate the list.
- Split ownership into more specific sub-paths under
/examples/(e.g./examples/llama2/,/examples/multimodal/, etc.) instead of one mega-line.- Keep owner handles in a consistent order (alphabetical or team-first).
Example quick fix for the duplication:
-/examples/ @hutm @biswapanda @ishandhanani ... @biswapanda ... @atchernych @ai-dynamo/Devops +/examples/ @hutm @biswapanda @ishandhanani ... @atchernych @ai-dynamo/DevopsA more thorough clean-up can be tackled in a follow-up PR.
🧹 Nitpick comments (1)
CODEOWNERS (1)
17-17: Addition looks fine, but keep the owner list alphabetised for readabilityNo functional problems, but since the list is growing it would help future readers if the handles were kept in alphabetical order (or another deterministic ordering).
|
Done in #1926 |
chore: Add user to dynamo deploy codeowners
Overview:
add atchernych to dynamo deploy codeowners
Details:
add atchernych to dynamo deploy codeowners
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit