fix: Fix mypy errors on trtllm examples

[tanmayv25]

Overview:

Updates type hints to fix mypy errors on pre-merge tests.

Summary by CodeRabbit

• Refactor
  • Improved support for asynchronous tasks, ensuring better handling of coroutine-based operations in threaded environments.

[coderabbitai]

Walkthrough

The type annotations for the task parameter and variable in the ManagedThread class were updated to indicate that the task is now expected to be an asynchronous coroutine function returning a boolean, instead of a synchronous function. No other logic or control flow was changed.

Changes

File(s)	Change Summary
examples/tensorrt_llm/common/utils.py	Updated type annotations for task in ManagedThread to expect an async coroutine returning bool

Poem

In code so neat, a thread awoke,
Now tasks must dance with async folk.
From sync to await, a subtle tune,
The rabbit hums beneath the moon.
Coroutines leap, the future’s bright—
Type hints guide us through the night!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e3c3b1 and 4696864.

📒 Files selected for processing (1)

• examples/tensorrt_llm/common/utils.py (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Mirror Repository to GitLab
• GitHub Check: Build and Test - vllm

🔇 Additional comments (3)

examples/tensorrt_llm/common/utils.py (3)

24-24: LGTM! Necessary import addition.

The Coroutine import is correctly added to support the updated type annotations.

---

57-59: Excellent type annotation fix!

The updated type annotation correctly reflects that the task parameter should be a coroutine function returning a bool, which aligns with its usage in the run method where it's passed to asyncio.run_coroutine_threadsafe(). This properly fixes the mypy type checking error.

---

79-81: Good type consistency maintenance.

The local variable type annotation is correctly updated to match the parameter type, ensuring type consistency throughout the method. This properly reflects that the task should be a coroutine when passed to asyncio.run_coroutine_threadsafe().

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rmccorm4]

Curious if there's a simpler type hint that encapsulates the same thing, but fine with fixing the errors for now

[tanmayv25]

Curious if there's a simpler type hint that encapsulates the same thing, but fine with fixing the errors for now

We always have Any :P. Will take a deeper look within the dynamo run framework.

[tanmayv25]

The pre-merge has passed on the launched pipeline.