build: Revert "chore: update nixl to 0.4.0 release" #1880
Conversation
This reverts commit 5fa4cdd.
nv-tusharma
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4 and
tanmayv25
as code owners
nv-tusharma
changed the title
WalkthroughThis change downgrades the NIXL dependency from version 0.4.0 to 0.3.1 across documentation, build scripts, and Rust dependency specifications. The commit hash for NIXL is updated in the build script, and the support matrix documentation reflects the new version alignment. No other logic or features are modified. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
container/build.sh (1)
117-119: Pin hash with context / tag or make it configurable.
NIXL_COMMIT=3503658e…is now hard-coded without a comment explaining the exact upstream tag (presumablyv0.3.1).
Future maintainers will have no clue which release this belongs to.Consider:
- NIXL_COMMIT=3503658e71143b56f9d5b1b440d84a94b9c41af8 + # v0.3.1 tag (2025-04-16) + NIXL_COMMIT=${NIXL_COMMIT:-3503658e71143b56f9d5b1b440d84a94b9c41af8}This documents the provenance and still allows overriding via env var.
docs/support_matrix.md (1)
84-86: Keep build-dependency footnote numbering in sync.The table footnotes
¹and²were left unchanged; verify they still point to the correct rows after editing.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
container/build.sh(1 hunks)docs/support_matrix.md(1 hunks)lib/llm/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: Build and Test - vllm
🔇 Additional comments (2)
lib/llm/Cargo.toml (1)
91-95: nixl-sys 0.3.1 downgrade verified – no breaking APIs in useA ripgrep check for the known 0.4.0–only symbols (
kv_cache::,NixlError::,set_global_allocator) returned zero matches inlib/. The downgrade to 0.3.1 should compile without re-introducing removed symbols.docs/support_matrix.md (1)
76-77: Double-check glibc minimum stays aligned with binary wheels.The downgrade bumped
NIXLto 0.3.1 but kept the glibc floor at>=2.27.
If the new wheel you ship was built on manylinux_2_28, the requirement should stay>=2.28. Please verify.
Reverts #1860
#1860
Summary by CodeRabbit