chore: update nixl to 0.4.0 release (#1860) #1886
Conversation
This reverts commit e9288ef.
nv-anants
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4 and
tanmayv25
as code owners
WalkthroughThis change updates the NIXL component across the codebase by bumping its version from 0.3.1 to 0.4.0 in documentation and dependency specifications, and by updating the referenced commit hash in the build script. No logic or control flow is altered. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
lib/llm/Cargo.toml (1)
91-93: Prefer a caret requirement to ease patch upgradesHard-pinning to
0.4.0forces another PR for every patch of nixl-sys.
Unless you need a very specific yanked fix, consider:-nixl-sys = {version = "0.4.0", optional = true } +nixl-sys = { version = "0.4", optional = true }This still prevents breaking semver changes (
0.5) while allowing0.4.xpatch updates automatically.docs/support_matrix.md (1)
84-86: Keep the footnote numbering consistent
TensorRT-LLMfootnote changed from “²” to “²” (no renumbering needed here), but if further rows are edited in future ensure the superscript references remain unique and in ascending order.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
container/build.sh(1 hunks)docs/support_matrix.md(1 hunks)lib/llm/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
lib/llm/Cargo.toml (1)
Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build and Test - vllm
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: pre-merge-rust (.)
🔇 Additional comments (2)
lib/llm/Cargo.toml (1)
89-94: No mismatchednixl-sysversions found across the workspaceI grepped every
Cargo.tomlfor anixl-sys = { version = … }specification and only the bump inlib/llm/Cargo.tomlto"0.4.0"shows up. There are no remaining crates depending on an older0.3.xseries.No further changes needed here.
docs/support_matrix.md (1)
74-77: Version bump looks goodThe runtime matrix now correctly reflects the
0.4.0release of NIXL.
Overview:
add nixl update back to main branch
Summary by CodeRabbit