-
Notifications
You must be signed in to change notification settings - Fork 689
docs: Adjust the path to examples #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe README.md file was updated to clarify the instructions for building and using the Dynamo base image. References to building and pushing images were revised, a note about prebuilt images on nvcr.io was added, and example commands for local testing were replaced with a reference to a Quickstart Guide. Changes
Estimated code review effort1 (~2 minutes) Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
71-77: Grammar & wording – “use … to your registry” is awkwardThe new sentence still reads as if a push is required (“use … to your container registry”).
Consider reverting to “push” or dropping “to your container registry” for clarity.-... will require you to use a Dynamo base image to your container registry. +... will require you to push a Dynamo base image to your container registry.
187-202: Quick-start link is inside a bash fence & will render as codeBecause the ```bash block opened at 187 isn’t closed before the “Follow the Quickstart Guide …” line, the link appears as literal text and is not clickable.
Close the fence first, then place the link outside.- pip install ".[all]" - - Follow the [Quickstart Guide](docs/guides/dynamo_deploy/quickstart.md) +pip install ".[all]" +``` + +Follow the [Quickstart Guide](docs/guides/dynamo_deploy/quickstart.md)
Overview:
Overall plan https://linear.app/nvidia-dynamo/issue/DYN-591/dynamo-user-experience-and-documentation-improvements
Details:
Linear Issue https://linear.app/nvidia-dynamo/issue/DYN-740/adjust-the-path-to-examples-after-they-were-moved-to-componentsbackend
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit