Skip to content

Conversation

@biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Jul 25, 2025

Overview:

Update vLLM container to use latest stable nixl release 0.4.1
release notes

start using/testing latest NIXL version in dynamo vLLM

🔴 This is a critical update and should be tested in CI thoroughly

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated the underlying build configuration to use a newer version of a dependency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2025

Walkthrough

This change updates the NIXL_REF build argument in container/Dockerfile.vllm to reference a new commit hash for the nixl repository. No other modifications or logic changes are included.

Changes

File(s) Summary
container/Dockerfile.vllm Updated NIXL_REF argument to new commit hash

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A Dockerfile tweak, so small and neat,
A hash replaced for nixl’s seat.
The build will pull a fresher vine,
With every byte, the code aligns.
Hop, hop, hooray for hashes new—
The rabbit’s work is nearly through! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff92053 and 96878f2.

📒 Files selected for processing (1)
  • container/Dockerfile.vllm (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
container/Dockerfile.vllm (1)

82-82: Action Required: Confirm v0.4.1 tag existence and commit match

It looks like the remote tag v0.4.1 could not be resolved to any commit, so we can’t verify that it points to the pinned hash. Before merging:

  • container/Dockerfile.vllm:82
    • Ensure the GitHub repo at https://github.com/ai-dynamo/nixl.git has a v0.4.1 tag.
    • Verify that this tag (annotated or lightweight) dereferences to commit fab120d8486ede919862033b8a6bfec81ef8f568.
    • If the tag is missing or points elsewhere, either update the NIXL_REF to the correct commit or create/move the v0.4.1 tag accordingly.
  • Update any docs, CI cache keys, or release notes still referencing the old commit.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@biswapanda biswapanda changed the title fix: update nixl veriosn to 0.4.1 (fab120d) fix: update nixl version to 0.4.1 (fab120d) Jul 25, 2025
@biswapanda biswapanda changed the title fix: update nixl version to 0.4.1 (fab120d) chore: update nixl version to 0.4.1 (fab120d) Jul 25, 2025
@github-actions github-actions bot added chore and removed fix labels Jul 25, 2025
Copy link
Contributor

@nv-anants nv-anants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed this before, could you update nixl-sys crate version too please - https://github.com/ai-dynamo/dynamo/blob/main/lib/llm/Cargo.toml#L92

@nv-anants nv-anants requested a review from a team as a code owner July 29, 2025 13:32
@nv-anants
Copy link
Contributor

Sorry missed this before, could you update nixl-sys crate version too please - https://github.com/ai-dynamo/dynamo/blob/main/lib/llm/Cargo.toml#L92

Actually, nvm. Pushed a commit to update the version. If all CI checks pass, you are good to go. Approving

@dmitry-tokarev-nv
Copy link
Contributor

@biswapanda I think we should close this PR in favor of #2221

@dmitry-tokarev-nv
Copy link
Contributor

closing in favor of #2221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants