fix: Dockerfile.sglang - Fixed sglang and dynamo wheels installaiton in ru… #2537
Conversation
dmitry-tokarev-nv
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4 and
tanmayv25
as code owners
|
/ok to test f631de7 |
WalkthroughThe Dockerfile now installs ai_dynamo_runtime, ai_dynamo, nixl wheels from /workspace/wheelhouse and pins sgLang via sgLang[all]==${SGLANG_VERSION}. It consolidates previous separate installs, switches source from /workspace/dist to /workspace/wheelhouse, and leaves prior commands commented for reference in both ci_minimum and runtime sections. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant D as Docker Build
participant S as Stage (ci_minimum/runtime)
participant P as pip
participant W as /workspace/wheelhouse
Dev->>D: Build with SGLANG_VERSION
D->>S: Execute install steps
S->>P: pip install ai_dynamo_runtime*cp312*.whl, ai_dynamo*any*.whl, nixl*.whl
S->>P: pip install sgLang[all]==${SGLANG_VERSION}
P->>W: Resolve wheel files
W-->>P: Provide wheels
P-->>S: Packages installed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
container/Dockerfile.sglang(1 hunks)
🔇 Additional comments (1)
container/Dockerfile.sglang (1)
475-480: Ensure no conflicting sglang requirement in ai_dynamo/ai_dynamo_runtime wheelsSince you’re explicitly pinning
sglang==${SGLANG_VERSION}in the Dockerfile, please verify that neither theai_dynamo_runtimenorai_dynamowheels in/workspace/wheelhousedeclare their ownsglangrequirement (which could override or conflict with your pin). You can do this by inspecting each wheel’s METADATA:• Run in your build context:
for wheel in /workspace/wheelhouse/ai_dynamo_runtime*cp*.whl \ /workspace/wheelhouse/ai_dynamo*any.whl; do echo "Checking $wheel" unzip -p "$wheel" METADATA \ | grep -E '^Requires-Dist: sglang' \ || echo " → no sglang requirement found" done• If you find a
Requires-Dist: sglangline with a version spec that doesn’t match${SGLANG_VERSION}, either:
- update that package’s spec to align with your pin, or
- install the wheel with
--no-deps(e.g.,pip install --no-deps …) to ignore its declared dependencies.
• Rebuild the container and confirm your pinned version is the one used at runtime.
|
/ok to test f581e0e |
|
addressed lychee workflow failure in #2538 |
|
/ok to test fb9ff5b |
…in ru… (#2537) Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
…ntime stage
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit