-
Notifications
You must be signed in to change notification settings - Fork 690
docs: update grove ref to new url #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anant Sharma <anants@nvidia.com>
WalkthroughUpdated a link in the "Using Grove (default)" subsection of the multinode deployment guide, changing the Grove integration reference from docs/getting-started.md to docs/installation.md. No other content was modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/guides/dynamo_deploy/multinode-deployment.md (2)
28-28: Nit: Tweak bullet formatting for consistency.Avoid starting a list item with a parenthetical; place “optional” after the bolded name.
Apply:
- - (optional) **[KAI-Scheduler](https://github.com/NVIDIA/KAI-Scheduler)**: Kubernetes native scheduler optimized for AI workloads at scale + - **[KAI-Scheduler](https://github.com/NVIDIA/KAI-Scheduler)** (optional): Kubernetes native scheduler optimized for AI workloads at scale
27-27: Verified Grove installation link; consider using a permalinkI’ve confirmed that the link to docs/installation.md is the correct, canonical installation guide and that no references to the old getting-started.md remain in the repo. To guard against future breaks (e.g., if the file moves), you may want to pin this URL to a release tag or commit SHA:
• File: docs/guides/dynamo_deploy/multinode-deployment.md (line 27)
• Example permalink:
https://github.com/NVIDIA/grove/blob/vX.Y.Z/docs/installation.md
(or use a specific commit SHA in place of vX.Y.Z)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/guides/dynamo_deploy/multinode-deployment.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/guides/dynamo_deploy/multinode-deployment.md
[grammar] ~27-~27: There might be a mistake here.
Context: ...duling and auto-scaling for AI workloads - (optional) **[KAI-Scheduler](https://git...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
Signed-off-by: Anant Sharma <anants@nvidia.com> Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Signed-off-by: Anant Sharma <anants@nvidia.com>
Overview:
fix broken links in docs
Summary by CodeRabbit