fix: fix #2653: links of h100_prefill_performance.png and h100_decode_performance.png #2650
Conversation
WalkthroughThe document docs/architecture/pre_deployment_profiling.md updates image references for Prefill and Decode Performance, changing paths from ../images/h100_.png to ../../docs/images/h100_.png. No other content or logic is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/architecture/pre_deployment_profiling.md (1)
58-58: Typo: stray closing brace in path literal.The path shows an extra '}' at the end, which can mislead readers when copy-pasting.
Fix:
-* `${benchmark_result_dir}/selected_prefill_interpolation/raw_data.npz}` +* `${benchmark_result_dir}/selected_prefill_interpolation/raw_data.npz`
🧹 Nitpick comments (2)
docs/architecture/pre_deployment_profiling.md (2)
51-51: Unify image path style for consistency.This still uses ../images while Lines 26–27 switched to ../../docs/images. Pick one style across the doc to avoid confusion (both resolve to the same target from this location).
Proposed change if you decide to follow the new style:
- +
26-27: Image links verified; optional path simplification suggestedAll three image paths in docs/architecture/pre_deployment_profiling.md resolve correctly on disk. No broken links were found:
- ../../docs/images/h100_prefill_performance.png → docs/images/h100_prefill_performance.png (OK)
- ../../docs/images/h100_decode_performance.png → docs/images/h100_decode_performance.png (OK)
- ../images/itl_interpolation.png → docs/images/itl_interpolation.png (OK)
Since the site generator’s baseUrl may influence which relative path is required, you can leave the existing
../../docs/images/...links if they’re necessary. Otherwise, for consistency with the shorter form used elsewhere in this file (e.g. line 51’s../images/itl_interpolation.png), you may optionally change the first two links to:-  -  +  + 
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/architecture/pre_deployment_profiling.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
docs/architecture/pre_deployment_profiling.md (1)
26-27: LGTM on fixing broken image links for H100 plots.The updated targets look plausible and will likely resolve the rendering issues for the two plots.
jasonqinzhou
changed the title
|
sorry, why we need this? looks like it's already inside the doc folder |
|
the link is broken. should be fixed. |
….png Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Bhuvan Agrawal <11240550+bhuvan002@users.noreply.github.com> Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
…t the ‘one-model’ solution as the default (#2661) Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com> Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
…2669) Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
jasonqinzhou
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
atchernych,
biswapanda,
grahamking,
hutm,
indrajit96,
ishandhanani,
julienmancuso,
kkranen,
krishung5,
mohammedabdulwahhab,
nealvaidya,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tmonty12 and
whoisj
as code owners
Signed-off-by: Jason Zhou <jasonzho@nvidia.com>
….png
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit