-
Notifications
You must be signed in to change notification settings - Fork 688
fix: hello world DGD #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hello world DGD #2732
Conversation
|
Caution Review failedFailed to post review comments. WalkthroughBroad updates across docs, configs, and code: switch default demo model to Qwen/Qwen3-0.6B; add SGLang readiness gate and tokenizer-init enforcement; refine error handling; add CRD/operator “sharedMemory” support; rework Helm templates for componentType; bump TRT‑LLM/vLLM/UCX versions; remove local async-openai-macros crate; add examples and docs reorg. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Frontend
participant SGLang as SGLang Runtime
participant Registrar as Model Registrar
Note over Frontend: Readiness gate
Frontend->>Registrar: register_llm_with_runtime_config(...)
par Start endpoint immediately
Frontend-->>Client: /v1/... generate endpoint available
and Register model concurrently
Registrar-->>Frontend: success(bool=true) or failure
end
alt Registration succeeds
Frontend->>Frontend: ready_event.set()
Client->>Frontend: generate(request)
Frontend->>Frontend: wait until ready_event
Frontend->>SGLang: handler.generate(request)
SGLang-->>Frontend: stream chunks
Frontend-->>Client: stream chunks
else Registration fails
Registrar->>Frontend: error
Frontend->>SGLang: shutdown()
Frontend-->>Client: error response
end
sequenceDiagram
autonumber
participant Operator as Operator Graph Builder
participant CRD as CRD Spec (sharedMemory)
participant K8s as Kubernetes
Operator->>CRD: read spec.sharedMemory {disabled,size}
alt disabled == true
Operator->>K8s: do not mount /dev/shm tmpfs
else not set or false
Operator->>K8s: create EmptyDir medium=Memory sizeLimit=(size or 8Gi)
Operator->>K8s: mount at /dev/shm (default path)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.2.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/product/migration-guide for migration instructions Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Overview:
cherry pick of #2727
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation