Skip to content

build: default to using dev instead of local-dev for vllm build #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

build: default to using dev instead of local-dev for vllm build #2834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c54f596
default to using dev instead of local-dev for dockerfile stage
nv-tusharma Sep 3, 2025
4cbe269
Merge branch 'main' into tusharma/fix-vllm-dev-target
nv-tusharma Sep 3, 2025
0d44031
update README.md
nv-tusharma Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .devcontainer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn

### Step 1: Build the Development Container Image

Build `dynamo:latest-vllm-local-dev` from scratch from the source:
- Note that currently, `local-dev` is only implemented for `--framework VLLM`.
Build `dynamo:latest-vllm` from scratch from the source:

```bash
./container/build.sh --target local-dev --framework VLLM
./container/build.sh --target dev --framework VLLM
```

The container will be built and give certain file permissions to your local uid and gid.
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"name": "NVIDIA Dynamo Dev Container Development",
"remoteUser": "ubuntu", // Matches our container user
"updateRemoteUserUID": true, // Updates the UID of the remote user to match the host user, avoids permission errors
"image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM local dev image
"image": "dynamo:latest-vllm", // Use the latest VLLM local dev image
"runArgs": [
"--gpus=all",
"--network=host",
Expand Down
2 changes: 1 addition & 1 deletion container/Dockerfile.vllm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ CMD []
# Use this stage when you need a full development environment with additional
# tooling beyond the base runtime image.

FROM runtime AS local-dev
FROM runtime AS dev

# Install utilities
RUN apt-get update -y && \
Expand Down
2 changes: 1 addition & 1 deletion container/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ fi
# Add NIXL_REF as a build argument
BUILD_ARGS+=" --build-arg NIXL_REF=${NIXL_REF} "

if [[ $TARGET == "local-dev" ]]; then
if [[ $TARGET == "dev" ]]; then
BUILD_ARGS+=" --build-arg USER_UID=$(id -u) --build-arg USER_GID=$(id -g) "
fi

Expand Down
Loading