-
Notifications
You must be signed in to change notification settings - Fork 688
fix: crates.io allows at most 5 keywords #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crates.io allows at most 5 keywords #3122
Conversation
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
WalkthroughRemoved the "dynamo" keyword from the [workspace.package] keywords array in Cargo.toml; no other fields or dependencies were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-05T22:51:59.230ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
Overview:
The crate
dynamo-parsersuses the workspace keywords when packaged. Howevercrates.ioonly allows 5 keywords and there are 6 listed. Removing Dynamo as that word is in the name of the crate and (hopefully) will turn up in searchSummary by CodeRabbit
Chores
No User-Facing Changes