Skip to content

Conversation

@saturley-hall
Copy link
Member

@saturley-hall saturley-hall commented Sep 18, 2025

Overview:

The crate dynamo-parsers uses the workspace keywords when packaged. However crates.io only allows 5 keywords and there are 6 listed. Removing Dynamo as that word is in the name of the crate and (hopefully) will turn up in search

Summary by CodeRabbit

  • Chores

    • Updated package metadata by removing the “dynamo” keyword from the published keywords list to better reflect current project scope and improve discoverability on package indexes.
  • No User-Facing Changes

    • No impact on features, APIs, configuration, performance, or build behavior.

Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

Removed the "dynamo" keyword from the [workspace.package] keywords array in Cargo.toml; no other fields or dependencies were changed.

Changes

Cohort / File(s) Summary
Workspace package metadata
Cargo.toml
Updated [workspace.package] keywords array by removing "dynamo"; array size reduced from 6 to 5. No other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A nibble at tags, a metadata trim,
I hop through Cargo with whiskers prim.
One word gone—light as a breeze,
The crate still hums with rustling ease.
Thump-thump, approve! Then off I scoot—
A tidy trail, and carrots to boot. 🥕

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provides a helpful Overview explaining why the keyword was removed but does not follow the repository's required template: the 'Details', 'Where should the reviewer start?', and 'Related Issues' sections are missing and the description does not explicitly call out the exact file and change (Cargo.toml: removal of "dynamo") shown in the raw_summary and pr_objectives, so the description is incomplete for reviewers. Please update the PR description to match the repository template by adding a 'Details' section that states Cargo.toml's [workspace.package].keywords had "dynamo" removed, a 'Where should the reviewer start?' pointing to Cargo.toml and the workspace.package block, and a 'Related Issues' entry (or "N/A"); optionally include short validation steps such as running cargo package locally or verifying packaging metadata in CI.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix: crates.io allows at most 5 keywords" succinctly identifies the primary intent of the change—addressing crates.io's five-keyword limit by removing a workspace keyword—and directly relates to the actual edit in Cargo.toml (removal of "dynamo"), making it clear and scannable for reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcf55c3 and 9095e1a.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2300
File: pyproject.toml:64-66
Timestamp: 2025-08-05T22:51:59.230Z
Learning: The ai-dynamo/dynamo project does not ship ARM64 wheels, so platform markers to restrict dependencies to x86_64 are not needed in pyproject.toml dependencies.
📚 Learning: 2025-08-05T22:51:59.230Z
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2300
File: pyproject.toml:64-66
Timestamp: 2025-08-05T22:51:59.230Z
Learning: The ai-dynamo/dynamo project does not ship ARM64 wheels, so platform markers to restrict dependencies to x86_64 are not needed in pyproject.toml dependencies.

Applied to files:

  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Build and Test - vllm
  • GitHub Check: Build and Test - sglang
  • GitHub Check: pre-merge-rust (lib/runtime/examples)
  • GitHub Check: pre-merge-rust (lib/bindings/python)
  • GitHub Check: pre-merge-rust (.)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
Cargo.toml (1)

26-26: Good fix — workspace keywords now comply with crates.io 5-keyword limit.
Verified with the provided script: all member crates have ≤5 effective keywords after workspace inheritance.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saturley-hall saturley-hall merged commit ef6734d into main Sep 18, 2025
15 checks passed
@saturley-hall saturley-hall deleted the harrison/fix-crates-can-only-have-5-keywords branch September 18, 2025 20:50
saturley-hall added a commit that referenced this pull request Sep 18, 2025
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
saturley-hall added a commit that referenced this pull request Sep 18, 2025
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants