From e1c0d57bf34e5a0d5ce9d4408dd842ee1fb88dc2 Mon Sep 17 00:00:00 2001 From: Kyle McGill Date: Mon, 17 Nov 2025 11:37:43 -0800 Subject: [PATCH 1/2] Fixing bug where TENSORRTLLM_PIP_WHEEL_DIR not being set. --- container/build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/container/build.sh b/container/build.sh index 75970e68b4..2fe39bb126 100755 --- a/container/build.sh +++ b/container/build.sh @@ -750,6 +750,8 @@ if [[ $FRAMEWORK == "TRTLLM" ]]; then BUILD_CONTEXT_ARG+=" --build-context trtllm_wheel=${TENSORRTLLM_PIP_WHEEL_DIR}" PRINT_TRTLLM_WHEEL_FILE=$(find $TENSORRTLLM_PIP_WHEEL_DIR -name "*.whl" | head -n 1) elif [[ "$TRTLLM_INTENTION" == "build" ]]; then + TENSORRTLLM_PIP_WHEEL_DIR=${TENSORRTLLM_PIP_WHEEL_DIR:=$DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR} + echo "TRTLLM pip wheel output directory is: ${TENSORRTLLM_PIP_WHEEL_DIR}" if [ "$DRY_RUN" != "true" ]; then GIT_URL_ARG="" if [ -n "${TRTLLM_GIT_URL}" ]; then From 0bbf7cddd9d0bac06c7b19ef1179c40e8cbc4f3c Mon Sep 17 00:00:00 2001 From: Kyle McGill Date: Mon, 17 Nov 2025 16:18:08 -0800 Subject: [PATCH 2/2] adding reasonable default for pip wheel dir and added testing for it --- container/build.sh | 2 +- tests/ci/test_build_sh.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/container/build.sh b/container/build.sh index 2fe39bb126..2cdf80b7f1 100755 --- a/container/build.sh +++ b/container/build.sh @@ -84,7 +84,7 @@ TRTLLM_BASE_IMAGE_TAG=25.06-py3 # By default, we will use option 1. If you want to use option 2, you can set # TENSORRTLLM_PIP_WHEEL to the TensorRT-LLM wheel on artifactory. # -# DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR="/tmp/trtllm_wheel/" +DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR="/tmp/trtllm_wheel/" # TensorRT-LLM commit to use for building the trtllm wheel if not provided. # Important Note: This commit is not used in our CI pipeline. See the CI diff --git a/tests/ci/test_build_sh.py b/tests/ci/test_build_sh.py index d6857e16a0..c5b183cf9d 100644 --- a/tests/ci/test_build_sh.py +++ b/tests/ci/test_build_sh.py @@ -283,6 +283,7 @@ def test_build_with_git_url_and_commit(self, build_script_path): assert "Intent to Download TRTLLM: false" in stdout assert "Intent to Install TRTLLM: false" in stdout assert "Intent to Build TRTLLM: true" in stdout + assert "TRTLLM pip wheel output directory is: /tmp/trtllm_wheel/" def test_build_with_git_url_and_wheel_dir(self, build_script_path, temp_wheel_dir): """Test build with --tensorrtllm-git-url and --tensorrtllm-pip-wheel-dir"""