[issue1146] Validate SAS file #227
Conversation
… InputFileLine in root_task
src/search/utils/input_file_parser.h
Outdated
| /* | ||
| Set context for error reporting. | ||
| */ | ||
| void set_context(const std::string &context); |
There was a problem hiding this comment.
Not sure if this is still relevant, but we have classes for the command line parsing that do something similar (for example SyntaxAnalyzerContext, DecorateContext, and ConstructContext, they are different private classes for different use cases but all parallel code). They have an advantage over setting the context manually because they leave the context once they go out of scope. This way you can produce error messages with a stack trace of contexts.
One suggestion would be to use a similar design here, another (more complicated) option would be to extract the common functionality.
| int num_facts = file_parser.read_line_int("number of facts in mutex group"); | ||
| if (num_facts < 1) { | ||
| file_parser.error("Number of facts in mutex group is less than 1, should be at least 1."); | ||
| } | ||
| vector<FactPair> invariant_group; | ||
| invariant_group.reserve(num_facts); | ||
| for (int j = 0; j < num_facts; ++j) { |
There was a problem hiding this comment.
Don't we already have a function that reads a list of facts? And doesn't it also need the check that there are no duplicate facts?
|
|
||
| // TODO: Maybe we could move this into a separate function as well |
| if(next_line != "") { | ||
| error("Expected end of file, found non-empty line " + next_line); | ||
| } | ||
| } |
There was a problem hiding this comment.
| } | |
| void InputFileParser::confirm_end_of_file() { | |
| assert(may_start_line); | |
| if (!stream.eof()) { | |
| line = find_next_line(); | |
| error("Expected end of file, found non-empty line " + line); | |
| } |
this would also remove the need of a bool flag in find_next_line.
| void TaskParser::confirm_end_of_input() { | ||
| find_next_line(false); | ||
| if(line != "") { | ||
| error("Expected end of task, found non-empty line " + line); |
There was a problem hiding this comment.
rename:
task -> task encoding
|
|
||
| class InputFileParser { | ||
| /* | ||
| Parse a task file. |
There was a problem hiding this comment.
rename:
task file -> task encoding
No description provided.